minor #24106 [DependencyInjection] Don't use return on Assert::markTestSkipped (derrabus)

fabpot · fabpot · commit a4a87ac3a368 · 2017-09-05T18:21:35.000-07:00
This PR was merged into the 3.3 branch. Discussion ---------- [DependencyInjection] Don't use return on Assert::markTestSkipped | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | N/A Removed an unnecessary return statement. `Assert::markTestSkipped()` will always throw an exception, so there's no need for a return statement here. And even if that method had a return value: A unit test is not supposed to return anything. Commits ------- 9cadeb8 Don't use return on Assert::markTestSkipped.
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/IniFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/IniFileLoaderTest.php
@@ -51,7 +51,7 @@ public function testTypeConversions($key, $value, $supported)
     public function testTypeConversionsWithNativePhp($key, $value, $supported)
     {
         if (defined('HHVM_VERSION_ID')) {
-            return $this->markTestSkipped();
+            $this->markTestSkipped();
         }
 
         if (!$supported) {

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function testTypeConversions($key, $value, $supported)`
`51`	`51`	`public function testTypeConversionsWithNativePhp($key, $value, $supported)`
`52`	`52`	`{`
`53`	`53`	`if (defined('HHVM_VERSION_ID')) {`
`54`		`- return $this->markTestSkipped();`
	`54`	`+ $this->markTestSkipped();`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`if (!$supported) {`