minor #33199 [VarDumper] Remove useless variable (ismail1432)

nicolas-grekas · nicolas-grekas · commit a3a4b190f3fd · 2019-08-16T07:43:03.000+02:00
This PR was submitted for the 4.4 branch but it was squashed and merged into the 3.4 branch instead (closes #33199). Discussion ---------- [VarDumper] Remove useless variable | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I think `$out` variable is useless in both case Commits ------- df47058 [VarDumper] Remove useless variable
diff --git a/src/Symfony/Component/VarDumper/Tests/Dumper/FunctionsTest.php b/src/Symfony/Component/VarDumper/Tests/Dumper/FunctionsTest.php
@@ -26,7 +26,7 @@ public function testDumpReturnsFirstArg()
 
         ob_start();
         $return = dump($var1);
-        $out = ob_get_clean();
+        ob_end_clean();
 
         $this->assertEquals($var1, $return);
     }
@@ -41,7 +41,7 @@ public function testDumpReturnsAllArgsInArray()
 
         ob_start();
         $return = dump($var1, $var2, $var3);
-        $out = ob_get_clean();
+        ob_end_clean();
 
         $this->assertEquals([$var1, $var2, $var3], $return);
     }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public function testDumpReturnsFirstArg()`
`26`	`26`
`27`	`27`	`ob_start();`
`28`	`28`	`$return = dump($var1);`
`29`		`- $out = ob_get_clean();`
	`29`	`+ ob_end_clean();`
`30`	`30`
`31`	`31`	`$this->assertEquals($var1, $return);`
`32`	`32`	`}`
`@@ -41,7 +41,7 @@ public function testDumpReturnsAllArgsInArray()`
`41`	`41`
`42`	`42`	`ob_start();`
`43`	`43`	`$return = dump($var1, $var2, $var3);`
`44`		`- $out = ob_get_clean();`
	`44`	`+ ob_end_clean();`
`45`	`45`
`46`	`46`	`$this->assertEquals([$var1, $var2, $var3], $return);`
`47`	`47`	`}`