bug #36483 [SecurityBundle] fix accepting env vars in remember-me configurations (zek)

nicolas-grekas · nicolas-grekas · commit a347a84453f6 · 2020-04-18T14:12:43.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] fix accepting env vars in remember-me configurations | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36271 | License | MIT | Doc PR | - As @wouterj explained we cannot use env variables after #35910 merged. > Hmm, so I'm guessing this is what happens: > > * `lifetime` is now an `integerNode()` > * For the Config component (which IIRC doesn't know anything about env variables), you're passing a string: `"%env(int:REMEMBER_ME_COOKIE_LIFETIME)%"` > * This throws an error, although if it wouldn't, the DI component would sucessfully process the string into a integer before it's used by any PHP class. > > So we either make Config aware of environment variables (that's probably a huge feature) or we revert the `integerNode()` changes (as you suggested). > > @HeahDude am I mislooking something, or would reverting these 2 lines not result in much harm? (only a little less strict config processor) Commits ------- 46c2783 [SecurityBundle] fix accepting env vars in remember-me configurations
diff --git a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php
@@ -146,8 +146,6 @@ public function addConfiguration(NodeDefinition $node)
         foreach ($this->options as $name => $value) {
             if (\is_bool($value)) {
                 $builder->booleanNode($name)->defaultValue($value);
-            } elseif (\is_int($value)) {
-                $builder->integerNode($name)->defaultValue($value);
             } else {
                 $builder->scalarNode($name)->defaultValue($value);
             }

Original file line number	Diff line number	Diff line change
`@@ -146,8 +146,6 @@ public function addConfiguration(NodeDefinition $node)`
`146`	`146`	`foreach ($this->options as $name => $value) {`
`147`	`147`	`if (\is_bool($value)) {`
`148`	`148`	`$builder->booleanNode($name)->defaultValue($value);`
`149`		`- } elseif (\is_int($value)) {`
`150`		`- $builder->integerNode($name)->defaultValue($value);`
`151`	`149`	`} else {`
`152`	`150`	`$builder->scalarNode($name)->defaultValue($value);`
`153`	`151`	`}`