bug #43589 [Lock] Fix incorrect return type in PostgreSqlStore (GromNaN)

fabpot · fabpot · commit a14ef913e196 · 2021-10-26T10:47:09.000+02:00
This PR was merged into the 5.3 branch. Discussion ---------- [Lock] Fix incorrect return type in PostgreSqlStore | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no [Reported by Psalm](https://github.com/symfony/symfony/pull/43587/checks?check_run_id=3939988273): ``` ERROR: UndefinedInterfaceMethod - src/Symfony/Component/Lock/Store/PostgreSqlStore.php:235:36 - Method Symfony\Component\Lock\PersistingStoreInterface::saveRead does not exist (see https://psalm.dev/181) $this->getInternalStore()->saveRead($key); ``` Commits ------- 729a019 [Lock] Fix incorrect return type in PostgreSqlStore
diff --git a/src/Symfony/Component/Lock/Store/PostgreSqlStore.php b/src/Symfony/Component/Lock/Store/PostgreSqlStore.php
@@ -18,7 +18,7 @@
 use Symfony\Component\Lock\Exception\InvalidArgumentException;
 use Symfony\Component\Lock\Exception\LockConflictedException;
 use Symfony\Component\Lock\Key;
-use Symfony\Component\Lock\PersistingStoreInterface;
+use Symfony\Component\Lock\SharedLockStoreInterface;
 
 /**
  * PostgreSqlStore is a PersistingStoreInterface implementation using
@@ -276,7 +276,7 @@ private function checkDriver(): void
         }
     }
 
-    private function getInternalStore(): PersistingStoreInterface
+    private function getInternalStore(): SharedLockStoreInterface
     {
         $namespace = spl_object_hash($this->getConnection());
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`use Symfony\Component\Lock\Exception\InvalidArgumentException;`
`19`	`19`	`use Symfony\Component\Lock\Exception\LockConflictedException;`
`20`	`20`	`use Symfony\Component\Lock\Key;`
`21`		`-use Symfony\Component\Lock\PersistingStoreInterface;`
	`21`	`+use Symfony\Component\Lock\SharedLockStoreInterface;`
`22`	`22`
`23`	`23`	`/**`
`24`	`24`	`* PostgreSqlStore is a PersistingStoreInterface implementation using`
`@@ -276,7 +276,7 @@ private function checkDriver(): void`
`276`	`276`	`}`
`277`	`277`	`}`
`278`	`278`
`279`		`- private function getInternalStore(): PersistingStoreInterface`
	`279`	`+ private function getInternalStore(): SharedLockStoreInterface`
`280`	`280`	`{`
`281`	`281`	`$namespace = spl_object_hash($this->getConnection());`
`282`	`282`