minor #58187 Pass validator.translation_domain to RequestPayloadValueResolver (raphael-geffroy)

nicolas-grekas · nicolas-grekas · commit a13836096a83 · 2024-09-10T09:05:30.000+02:00
This PR was merged into the 7.2 branch. Discussion ---------- Pass `validator.translation_domain` to `RequestPayloadValueResolver` | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix #58170 | License | MIT Replaces hardcoded validation translation domain by container param `validator.translation_domain`. Used [UploadValidatorExtension](https://github.com/symfony/symfony/blob/7f15676de99eae53b5b818a038b1bf070577b341/src/Symfony/Component/Form/Extension/Validator/Type/UploadValidatorExtension.php#L24) as inspiration. Commits ------- 2d45107 fix: pass validator.translation_domain to RequestPayloadValueResolver
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/web.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/web.php
@@ -71,6 +71,7 @@
                 service('serializer'),
                 service('validator')->nullOnInvalid(),
                 service('translator')->nullOnInvalid(),
+                param('validator.translation_domain'),
             ])
             ->tag('controller.targeted_value_resolver', ['name' => RequestPayloadValueResolver::class])
             ->tag('kernel.event_subscriber')
diff --git a/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/RequestPayloadValueResolver.php b/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/RequestPayloadValueResolver.php
@@ -65,6 +65,7 @@ public function __construct(
         private readonly SerializerInterface&DenormalizerInterface $serializer,
         private readonly ?ValidatorInterface $validator = null,
         private readonly ?TranslatorInterface $translator = null,
+        private string $translationDomain = 'validators',
     ) {
     }
 
@@ -137,7 +138,7 @@ public function onKernelControllerArguments(ControllerArgumentsEvent $event): vo
                         if ($error->canUseMessageForUser()) {
                             $parameters['hint'] = $error->getMessage();
                         }
-                        $message = $trans($template, $parameters, 'validators');
+                        $message = $trans($template, $parameters, $this->translationDomain);
                         $violations->add(new ConstraintViolation($message, $template, $parameters, null, $error->getPath(), null));
                     }
                     $payload = $e->getData();

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ public function __construct(`
`65`	`65`	`private readonly SerializerInterface&DenormalizerInterface $serializer,`
`66`	`66`	`private readonly ?ValidatorInterface $validator = null,`
`67`	`67`	`private readonly ?TranslatorInterface $translator = null,`
	`68`	`+ private string $translationDomain = 'validators',`
`68`	`69`	`) {`
`69`	`70`	`}`
`70`	`71`
`@@ -137,7 +138,7 @@ public function onKernelControllerArguments(ControllerArgumentsEvent $event): vo`
`137`	`138`	`if ($error->canUseMessageForUser()) {`
`138`	`139`	`$parameters['hint'] = $error->getMessage();`
`139`	`140`	`}`
`140`		`- $message = $trans($template, $parameters, 'validators');`
	`141`	`+ $message = $trans($template, $parameters, $this->translationDomain);`
`141`	`142`	`$violations->add(new ConstraintViolation($message, $template, $parameters, null, $error->getPath(), null));`
`142`	`143`	`}`
`143`	`144`	`$payload = $e->getData();`