bug #42212 [Lock] Handle lock with long key (jderusse)

fabpot · fabpot · commit a0d0c22a9ee9 · 2021-07-23T08:00:10.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Lock] Handle lock with long key | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - When lock key is very long, the generated file exceeded the maximum length supported by the system, leading to an exception `fopen(/tmp/sf.username_xxxxxxxx[...].d3rUs2a.lock): Failed to open stream: File name too long` Commits ------- f826824 Handle lock with long key
diff --git a/src/Symfony/Component/Lock/Store/FlockStore.php b/src/Symfony/Component/Lock/Store/FlockStore.php
@@ -74,7 +74,7 @@ private function lock(Key $key, bool $blocking)
 
         $fileName = sprintf('%s/sf.%s.%s.lock',
             $this->lockPath,
-            preg_replace('/[^a-z0-9\._-]+/i', '-', $key),
+            substr(preg_replace('/[^a-z0-9\._-]+/i', '-', $key), 0, 50),
             strtr(substr(base64_encode(hash('sha256', $key, true)), 0, 7), '/', '_')
         );
 
diff --git a/src/Symfony/Component/Lock/Tests/Store/FlockStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/FlockStoreTest.php
@@ -73,4 +73,25 @@ public function testSaveSanitizeName()
 
         $store->delete($key);
     }
+
+    public function testSaveSanitizeLongName()
+    {
+        $store = $this->getStore();
+
+        $key = new Key(str_repeat(__CLASS__, 100));
+
+        $file = sprintf(
+            '%s/sf.Symfony-Component-Lock-Tests-Store-FlockStoreTestS.%s.lock',
+            sys_get_temp_dir(),
+            strtr(substr(base64_encode(hash('sha256', $key, true)), 0, 7), '/', '_')
+        );
+        // ensure the file does not exist before the store
+        @unlink($file);
+
+        $store->save($key);
+
+        $this->assertFileExists($file);
+
+        $store->delete($key);
+    }
 }
