minor #18932 Improve memory efficiency (Dword123)

nicolas-grekas · nicolas-grekas · commit a004fc7526a9 · 2016-06-03T13:01:18.000+02:00
This PR was merged into the 2.7 branch.

Discussion
----------

Improve memory efficiency

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This avoids concatenating `$message` and `PHP_EOL` (if necessary) as a new value, greatly improving memory efficiency for large `$message`s.

Commits
-------

c1df9f2 Improve memory efficiency
diff --git a/src/Symfony/Component/Console/Output/StreamOutput.php b/src/Symfony/Component/Console/Output/StreamOutput.php
@@ -70,7 +70,7 @@ public function getStream()
      */
     protected function doWrite($message, $newline)
     {
-        if (false === @fwrite($this->stream, $message.($newline ? PHP_EOL : ''))) {
+        if (false === @fwrite($this->stream, $message) || ($newline && (false === @fwrite($this->stream, PHP_EOL)))) {
             // should never happen
             throw new \RuntimeException('Unable to write output.');
         }

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public function getStream()`
`70`	`70`	`*/`
`71`	`71`	`protected function doWrite($message, $newline)`
`72`	`72`	`{`
`73`		`- if (false === @fwrite($this->stream, $message.($newline ? PHP_EOL : ''))) {`
	`73`	`+ if (false === @fwrite($this->stream, $message) \|\| ($newline && (false === @fwrite($this->stream, PHP_EOL)))) {`
`74`	`74`	`// should never happen`
`75`	`75`	`throw new \RuntimeException('Unable to write output.');`
`76`	`76`	`}`