Prefer $_SERVER['argv'] over $argv.

ricardodevries · ricardodevries · commit 9f8c89bd4daa · 2017-12-04T13:49:37.000+01:00
diff --git a/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit b/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit
@@ -120,7 +120,7 @@ EOPHP
 }
 
 $components = array();
-$cmd = array_map('escapeshellarg', $argv);
+$cmd = array_map('escapeshellarg', $_SERVER['argv']);
 $exit = 0;
 
 if (isset($argv[1]) && 'symfony' === $argv[1] && !file_exists('symfony') && file_exists('src/Symfony')) {
@@ -230,9 +230,8 @@ if ($components) {
     if (!class_exists('SymfonyBlacklistSimplePhpunit', false)) {
         class SymfonyBlacklistSimplePhpunit {}
     }
-    array_splice($argv, 1, 0, array('--colors=always'));
-    $_SERVER['argv'] = $argv;
-    $_SERVER['argc'] = ++$argc;
+    array_splice($_SERVER['argv'], 1, 0, array('--colors=always'));
+
     include "$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit";
 }
 

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ EOPHP`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`$components = array();`
`123`		`-$cmd = array_map('escapeshellarg', $argv);`
	`123`	`+$cmd = array_map('escapeshellarg', $_SERVER['argv']);`
`124`	`124`	`$exit = 0;`
`125`	`125`
`126`	`126`	`if (isset($argv[1]) && 'symfony' === $argv[1] && !file_exists('symfony') && file_exists('src/Symfony')) {`
`@@ -230,9 +230,8 @@ if ($components) {`
`230`	`230`	`if (!class_exists('SymfonyBlacklistSimplePhpunit', false)) {`
`231`	`231`	`class SymfonyBlacklistSimplePhpunit {}`
`232`	`232`	`}`
`233`		`- array_splice($argv, 1, 0, array('--colors=always'));`
`234`		`- $_SERVER['argv'] = $argv;`
`235`		`- $_SERVER['argc'] = ++$argc;`
	`233`	`+ array_splice($_SERVER['argv'], 1, 0, array('--colors=always'));`
	`234`	`+`
`236`	`235`	`include "$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit";`
`237`	`236`	`}`
`238`	`237`