feature #54084 [Lock] Make NoLock implement the SharedLockInterface (mbabker)

nicolas-grekas · nicolas-grekas · commit 9e810dea50cb · 2024-02-27T16:38:39.000+01:00
This PR was merged into the 7.1 branch. Discussion ---------- [Lock] Make NoLock implement the SharedLockInterface | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix #53713 | License | MIT This PR updates the `Symfony\Component\Lock\NoLock` stub to implement `Symfony\Component\Lock\SharedLockInterface` and returns it to being compatible with the `Symfony\Component\Lock\LockFactory` return types. Commits ------- 22600d0 Make NoLock implement the SharedLockInterface
diff --git a/src/Symfony/Component/Lock/NoLock.php b/src/Symfony/Component/Lock/NoLock.php
@@ -19,8 +19,13 @@
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
  */
-final class NoLock implements LockInterface
+final class NoLock implements SharedLockInterface
 {
+    public function acquireRead(bool $blocking = false): bool
+    {
+        return true;
+    }
+
     public function acquire(bool $blocking = false): bool
     {
         return true;

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,13 @@`
`19`	`19`	`*`
`20`	`20`	`* @author Wouter de Jong <wouter@wouterj.nl>`
`21`	`21`	`*/`
`22`		`-final class NoLock implements LockInterface`
	`22`	`+final class NoLock implements SharedLockInterface`
`23`	`23`	`{`
	`24`	`+ public function acquireRead(bool $blocking = false): bool`
	`25`	`+ {`
	`26`	`+ return true;`
	`27`	`+ }`
	`28`	`+`
`24`	`29`	`public function acquire(bool $blocking = false): bool`
`25`	`30`	`{`
`26`	`31`	`return true;`