bug #35538 [FrameworkBundle] fixed suggesting deprecated WebServerBundle (jrushlow)

fabpot · fabpot · commit 9d7e622e5b36 · 2020-01-31T13:35:48.000+01:00
This PR was squashed before being merged into the 5.1-dev branch (closes #35538). Discussion ---------- [FrameworkBundle] fixed suggesting deprecated WebServerBundle | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35495 | License | MIT | Doc PR | Removed suggestion to install `symfony/web-server-bundle` in console missing packages suggestions. The web server bundle was deprecated and no longer works with Symfony 5.x, . Commits ------- 134129b [FrameworkBundle] fixed suggesting deprecated WebServerBundle
diff --git a/src/Symfony/Bundle/FrameworkBundle/EventListener/SuggestMissingPackageSubscriber.php b/src/Symfony/Bundle/FrameworkBundle/EventListener/SuggestMissingPackageSubscriber.php
@@ -39,8 +39,7 @@ final class SuggestMissingPackageSubscriber implements EventSubscriberInterface
             '_default' => ['MakerBundle', 'symfony/maker-bundle --dev'],
         ],
         'server' => [
-            'dump' => ['Debug Bundle', 'symfony/debug-bundle --dev'],
-            '_default' => ['WebServerBundle', 'symfony/web-server-bundle --dev'],
+            '_default' => ['Debug Bundle', 'symfony/debug-bundle --dev'],
         ],
     ];
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Console/ApplicationTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Console/ApplicationTest.php
@@ -208,7 +208,7 @@ public function testRunOnlyWarnsOnUnregistrableCommandAtTheEnd()
 
     public function testSuggestingPackagesWithExactMatch()
     {
-        $result = $this->createEventForSuggestingPackages('server:dump', []);
+        $result = $this->createEventForSuggestingPackages('doctrine:fixtures', []);
         $this->assertRegExp('/You may be looking for a command provided by/', $result);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ public function testRunOnlyWarnsOnUnregistrableCommandAtTheEnd()`
`208`	`208`
`209`	`209`	`public function testSuggestingPackagesWithExactMatch()`
`210`	`210`	`{`
`211`		`- $result = $this->createEventForSuggestingPackages('server:dump', []);`
	`211`	`+ $result = $this->createEventForSuggestingPackages('doctrine:fixtures', []);`
`212`	`212`	`$this->assertRegExp('/You may be looking for a command provided by/', $result);`
`213`	`213`	`}`
`214`	`214`