minor #58538 [HttpFoundation] session names must not be empty (xabbuh)

xabbuh · xabbuh · commit 9d3e371edc43 · 2024-10-11T20:57:56.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [HttpFoundation] session names must not be empty | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT The changes done in #58453 were not enough. Since the session name is used as the cookie name it must not be the empty string. Commits ------- 4d595f4 session names must not be empty
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/AbstractRedisSessionHandlerTestCase.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/AbstractRedisSessionHandlerTestCase.php
@@ -106,7 +106,7 @@ public function testUseSessionGcMaxLifetimeAsTimeToLive()
 
     public function testDestroySession()
     {
-        $this->storage->open('', '');
+        $this->storage->open('', 'test');
         $this->redisClient->set(self::PREFIX.'id', 'foo');
 
         $this->assertTrue((bool) $this->redisClient->exists(self::PREFIX.'id'));
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php
@@ -119,7 +119,7 @@ public function testWriteSessionWithLargeTTL()
 
     public function testDestroySession()
     {
-        $this->storage->open('', '');
+        $this->storage->open('', 'sid');
         $this->memcached
             ->expects($this->once())
             ->method('delete')

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ public function testUseSessionGcMaxLifetimeAsTimeToLive()`
`106`	`106`
`107`	`107`	`public function testDestroySession()`
`108`	`108`	`{`
`109`		`- $this->storage->open('', '');`
	`109`	`+ $this->storage->open('', 'test');`
`110`	`110`	`$this->redisClient->set(self::PREFIX.'id', 'foo');`
`111`	`111`
`112`	`112`	`$this->assertTrue((bool) $this->redisClient->exists(self::PREFIX.'id'));`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ public function testWriteSessionWithLargeTTL()`
`119`	`119`
`120`	`120`	`public function testDestroySession()`
`121`	`121`	`{`
`122`		`- $this->storage->open('', '');`
	`122`	`+ $this->storage->open('', 'sid');`
`123`	`123`	`$this->memcached`
`124`	`124`	`->expects($this->once())`
`125`	`125`	`->method('delete')`