[Validator] Allow empty string

neufman · neufman · commit 9c07484b0fb4 · 2022-04-11T14:07:33.000+02:00
Allow empty string if "min" option is null to match documentation "As with most of the other constraints, null and empty strings are considered valid values".
diff --git a/src/Symfony/Component/Validator/Constraints/LengthValidator.php b/src/Symfony/Component/Validator/Constraints/LengthValidator.php
@@ -30,7 +30,7 @@ public function validate(mixed $value, Constraint $constraint)
             throw new UnexpectedTypeException($constraint, Length::class);
         }
 
-        if (null === $value) {
+        if (null === $value || ('' === $value && !$constraint->min )) {
             return;
         }
 
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/LengthValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/LengthValidatorTest.php
@@ -30,7 +30,14 @@ public function testNullIsValid()
         $this->assertNoViolation();
     }
 
-    public function testEmptyStringIsInvalid()
+    public function testEmptyStringIsValidWithoutMin()
+    {
+        $this->validator->validate('', new Length(['max' => 6]));
+
+        $this->assertNoViolation();
+    }
+
+    public function testEmptyStringIsInvalidWithMin()
     {
         $this->validator->validate('', new Length([
             'value' => $limit = 6,

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function validate(mixed $value, Constraint $constraint)`
`30`	`30`	`throw new UnexpectedTypeException($constraint, Length::class);`
`31`	`31`	`}`
`32`	`32`
`33`		`- if (null === $value) {`
	`33`	`+ if (null === $value \|\| ('' === $value && !$constraint->min )) {`
`34`	`34`	`return;`
`35`	`35`	`}`
`36`	`36`