feature #28854 [VarDumper] Scroll into view when searching (ro0NL)

fabpot · fabpot · commit 9bb60c9642da · 2018-10-27T18:01:10.000+02:00
This PR was merged into the 4.2-dev branch. Discussion ---------- [VarDumper] Scroll into view when searching | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no  | Deprecations? | no | Tests pass? | yes  | Fixed tickets | #...  | License | MIT | Doc PR | symfony/symfony-docs#...  This jumps to the found element when using the javascript widget for searching HTML dumps. Inspired by Ctrl+F in Chrome :) It's super convenient with long dumps, however i wasnt able to position the search input on the right in a fixed manner... because CSS 😓 i was hoping @ogizanagi could add a patch for it. Also see https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView Commits ------- 647a937 [VarDumper] Scroll into view when searching
diff --git a/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php b/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
@@ -504,6 +504,9 @@ function showCurrent(state)
             if (currentNode) {
                 reveal(currentNode);
                 highlight(root, currentNode, state.nodes);
+                if ('scrollIntoView' in currentNode) {
+                    currentNode.scrollIntoView();
+                }
             }
             counter.textContent = (state.isEmpty() ? 0 : state.idx + 1) + ' of ' + state.count();
         }

Original file line number	Diff line number	Diff line change
`@@ -504,6 +504,9 @@ function showCurrent(state)`
`504`	`504`	`if (currentNode) {`
`505`	`505`	`reveal(currentNode);`
`506`	`506`	`highlight(root, currentNode, state.nodes);`
	`507`	`+ if ('scrollIntoView' in currentNode) {`
	`508`	`+ currentNode.scrollIntoView();`
	`509`	`+ }`
`507`	`510`	`}`
`508`	`511`	`counter.textContent = (state.isEmpty() ? 0 : state.idx + 1) + ' of ' + state.count();`
`509`	`512`	`}`