bug #30973 [WebProfiler] Fix Javascript error when using custom stopwatch categories (curry684)

fabpot · fabpot · commit 9b9d416cf654 · 2019-04-08T11:00:23.000+02:00
This PR was squashed before being merged into the 4.3-dev branch (closes #30973). Discussion ---------- [WebProfiler] Fix Javascript error when using custom stopwatch categories Fixes #30745 | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30745 | License | MIT Made the getter do lazy creation so it can dynamically adapt to whatever it's given. Commits ------- e991472 [WebProfiler] Fix Javascript error when using custom stopwatch categories
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.js b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.js
@@ -252,11 +252,11 @@ class Legend {
     }
 
     get(category) {
-        return this.categories.find(element => element.value === category);
+        return this.categories.find(element => element.value === category) || this.createCategory(category);
     }
 
     getClassname(category) {
-        return this.classnames[category];
+        return this.classnames[category] || '';
     }
 
     getSectionClassname() {

Original file line number	Diff line number	Diff line change
`@@ -252,11 +252,11 @@ class Legend {`
`252`	`252`	`}`
`253`	`253`
`254`	`254`	`get(category) {`
`255`		`- return this.categories.find(element => element.value === category);`
	`255`	`+ return this.categories.find(element => element.value === category) \|\| this.createCategory(category);`
`256`	`256`	`}`
`257`	`257`
`258`	`258`	`getClassname(category) {`
`259`		`- return this.classnames[category];`
	`259`	`+ return this.classnames[category] \|\| '';`
`260`	`260`	`}`
`261`	`261`
`262`	`262`	`getSectionClassname() {`