minor #39720 make some time dependent tests more resilient (xabbuh)

nicolas-grekas · nicolas-grekas · commit 9b719ab13d59 · 2021-01-05T19:32:49.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- make some time dependent tests more resilient | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- a33850e make some time dependent tests more resilient
diff --git a/src/Symfony/Component/Config/Tests/Resource/DirectoryResourceTest.php b/src/Symfony/Component/Config/Tests/Resource/DirectoryResourceTest.php
@@ -110,7 +110,7 @@ public function testIsFreshDeleteFile()
     {
         $resource = new DirectoryResource($this->directory);
         $time = time();
-        sleep(1);
+        usleep(1500000);
         unlink($this->directory.'/tmp.xml');
         $this->assertFalse($resource->isFresh($time), '->isFresh() returns false if an existing file is removed');
     }
diff --git a/src/Symfony/Component/Mailer/Tests/Transport/Smtp/SmtpTransportTest.php b/src/Symfony/Component/Mailer/Tests/Transport/Smtp/SmtpTransportTest.php
@@ -22,6 +22,9 @@
 use Symfony\Component\Mime\Exception\InvalidArgumentException;
 use Symfony\Component\Mime\RawMessage;
 
+/**
+ * @group time-sensitive
+ */
 class SmtpTransportTest extends TestCase
 {
     public function testToString()
@@ -83,7 +86,7 @@ public function testSendDoesPingAboveThreshold()
         $this->assertNotContains("NOOP\r\n", $stream->getCommands());
 
         $stream->clearCommands();
-        sleep(1);
+        usleep(1500000);
 
         $transport->send(new RawMessage('Message 3'), $envelope);
         $this->assertContains("NOOP\r\n", $stream->getCommands());

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ public function testIsFreshDeleteFile()`
`110`	`110`	`{`
`111`	`111`	`$resource = new DirectoryResource($this->directory);`
`112`	`112`	`$time = time();`
`113`		`- sleep(1);`
	`113`	`+ usleep(1500000);`
`114`	`114`	`unlink($this->directory.'/tmp.xml');`
`115`	`115`	`$this->assertFalse($resource->isFresh($time), '->isFresh() returns false if an existing file is removed');`
`116`	`116`	`}`