bug #29482 Fixes sprintf(): Too few arguments in MessageFormatter::choiceFormat (stephanedelprat)

nicolas-grekas · nicolas-grekas · commit 9b25b6a2642c · 2018-12-06T10:45:39.000Z
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #29482). Discussion ---------- Fixes sprintf(): Too few arguments in MessageFormatter::choiceFormat Similar to : #29344 | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | related to a previous deprecation  | Tests pass? | I hope so | Fixed tickets | none | License | MIT | Doc PR | none Fixes the log produced when the method is called : Before : "sprintf(): Too few arguments" After : "The "Symfony\Component\Translation\Formatter\MessageFormatter::choiceFormat()" method is deprecated since Symfony 4.2, use the format() one instead with a %count% parameter." Reference : http://php.net/manual/function.sprintf.php Commits ------- 109fee5 Fixes sprintf(): Too few arguments in Translator
diff --git a/src/Symfony/Component/Translation/Formatter/MessageFormatter.php b/src/Symfony/Component/Translation/Formatter/MessageFormatter.php
@@ -66,7 +66,7 @@ public function formatIntl(string $message, string $locale, array $parameters =
      */
     public function choiceFormat($message, $number, $locale, array $parameters = array())
     {
-        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the format() one instead with a %count% parameter.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the format() one instead with a %%count%% parameter.', __METHOD__), E_USER_DEPRECATED);
 
         $parameters = array('%count%' => $number) + $parameters;
 

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public function formatIntl(string $message, string $locale, array $parameters =`
`66`	`66`	`*/`
`67`	`67`	`public function choiceFormat($message, $number, $locale, array $parameters = array())`
`68`	`68`	`{`
`69`		`- @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the format() one instead with a %count% parameter.', __METHOD__), E_USER_DEPRECATED);`
	`69`	`+ @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the format() one instead with a %%count%% parameter.', __METHOD__), E_USER_DEPRECATED);`
`70`	`70`
`71`	`71`	`$parameters = array('%count%' => $number) + $parameters;`
`72`	`72`