feature #26832 [MonologBridge] Added WebSubscriberProcessor to ease processor configuration (lyrixx)

fabpot · fabpot · commit 9ae116f9e521 · 2018-04-23T13:44:44.000+02:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [MonologBridge] Added WebSubscriberProcessor to ease processor configuration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | --- Side note: I could be nice to have an interface to act as the marker to AutoConfigure processors Commits ------- b1287d6 [MonologBridge] Added WebSubscriberProcessor to ease processor configuration
diff --git a/src/Symfony/Bridge/Monolog/CHANGELOG.md b/src/Symfony/Bridge/Monolog/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+4.1.0
+-----
+
+ * `WebProcessor` now implements `EventSubscriberInterface` in order to be easily autoconfigured
+
 4.0.0
 -----
 
diff --git a/src/Symfony/Bridge/Monolog/Processor/WebProcessor.php b/src/Symfony/Bridge/Monolog/Processor/WebProcessor.php
@@ -12,14 +12,16 @@
 namespace Symfony\Bridge\Monolog\Processor;
 
 use Monolog\Processor\WebProcessor as BaseWebProcessor;
+use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\HttpKernel\Event\GetResponseEvent;
+use Symfony\Component\HttpKernel\KernelEvents;
 
 /**
  * WebProcessor override to read from the HttpFoundation's Request.
  *
  * @author Jordi Boggiano <j.boggiano@seld.be>
  */
-class WebProcessor extends BaseWebProcessor
+class WebProcessor extends BaseWebProcessor implements EventSubscriberInterface
 {
     public function __construct(array $extraFields = null)
     {
@@ -34,4 +36,11 @@ public function onKernelRequest(GetResponseEvent $event)
             $this->serverData['REMOTE_ADDR'] = $event->getRequest()->getClientIp();
         }
     }
+
+    public static function getSubscribedEvents()
+    {
+        return array(
+            KernelEvents::REQUEST => array('onKernelRequest', 4096),
+        );
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -12,14 +12,16 @@`
`12`	`12`	`namespace Symfony\Bridge\Monolog\Processor;`
`13`	`13`
`14`	`14`	`use Monolog\Processor\WebProcessor as BaseWebProcessor;`
	`15`	`+use Symfony\Component\EventDispatcher\EventSubscriberInterface;`
`15`	`16`	`use Symfony\Component\HttpKernel\Event\GetResponseEvent;`
	`17`	`+use Symfony\Component\HttpKernel\KernelEvents;`
`16`	`18`
`17`	`19`	`/**`
`18`	`20`	`* WebProcessor override to read from the HttpFoundation's Request.`
`19`	`21`	`*`
`20`	`22`	`* @author Jordi Boggiano <j.boggiano@seld.be>`
`21`	`23`	`*/`
`22`		`-class WebProcessor extends BaseWebProcessor`
	`24`	`+class WebProcessor extends BaseWebProcessor implements EventSubscriberInterface`
`23`	`25`	`{`
`24`	`26`	`public function __construct(array $extraFields = null)`
`25`	`27`	`{`
`@@ -34,4 +36,11 @@ public function onKernelRequest(GetResponseEvent $event)`
`34`	`36`	`$this->serverData['REMOTE_ADDR'] = $event->getRequest()->getClientIp();`
`35`	`37`	`}`
`36`	`38`	`}`
	`39`	`+`
	`40`	`+ public static function getSubscribedEvents()`
	`41`	`+ {`
	`42`	`+ return array(`
	`43`	`+ KernelEvents::REQUEST => array('onKernelRequest', 4096),`
	`44`	`+ );`
	`45`	`+ }`
`37`	`46`	`}`