remove useless check

alcalyn · alcalyn · commit 9aae7a27a1eb · 2018-07-04T18:13:01.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/CheckTypeHintsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/CheckTypeHintsPass.php
@@ -149,10 +149,10 @@ private function getClassName($value)
             } elseif (null === $class) {
                 $class = $value->getClass();
             } elseif ($class instanceof Definition) {
-                $class = $class->getClass();
+                $class = $this->getClassName($class);
             }
         } else {
-            $class = is_string($factory) ? null : $value->getClass();
+            $class = $value->getClass();
         }
 
         return $class;

Original file line number	Diff line number	Diff line change
`@@ -149,10 +149,10 @@ private function getClassName($value)`
`149`	`149`	`} elseif (null === $class) {`
`150`	`150`	`$class = $value->getClass();`
`151`	`151`	`} elseif ($class instanceof Definition) {`
`152`		`- $class = $class->getClass();`
	`152`	`+ $class = $this->getClassName($class);`
`153`	`153`	`}`
`154`	`154`	`} else {`
`155`		`- $class = is_string($factory) ? null : $value->getClass();`
	`155`	`+ $class = $value->getClass();`
`156`	`156`	`}`
`157`	`157`
`158`	`158`	`return $class;`