8000 [Scheduler] Fix tests · symfony/symfony@9aa5247 · GitHub
[go: up one dir, main page]
Skip to content

Commit 9aa5247

Browse files
fabpotfabpot
committed
[Scheduler] Fix tests
1 parent 19f0093 commit 9aa5247

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Messenger/DummyTask.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
use Symfony\Component\Scheduler\Attribute\AsCronTask;
66
use Symfony\Component\Scheduler\Attribute\AsPeriodicTask;
77

8-
#[AsCronTask(expression: '* * * * *', arguments: [1], schedule: 'dummy')]
9-
#[AsCronTask(expression: '0 * * * *', timezone: 'Europe/Berlin', arguments: ['2'], schedule: 'dummy', method: 'method2')]
10-
#[AsPeriodicTask(frequency: 5, arguments: [3], schedule: 'dummy')]
11-
#[AsPeriodicTask(frequency: 'every day', from: '00:00:00', jitter: 60, arguments: ['4'], schedule: 'dummy', method: 'method4')]
8+
#[AsCronTask(expression: '* * * * *', arguments: [1], schedule: 'dummy_task')]
9+
#[AsCronTask(expression: '0 * * * *', timezone: 'Europe/Berlin', arguments: ['2'], schedule: 'dummy_task', method: 'method2')]
10+
#[AsPeriodicTask(frequency: 5, arguments: [3], schedule: 'dummy_task')]
11+
#[AsPeriodicTask(frequency: '1 day', from: '00:00:00', jitter: 60, arguments: ['4'], schedule: 'dummy_task', method: 'method4')]
1212
class DummyTask
1313
{
1414
public static array $calls = [];
1515

16-
#[AsPeriodicTask(frequency: 'every hour', from: '09:00:00', until: '17:00:00', arguments: ['b' => 6, 'a' => '5'], schedule: 'dummy')]
17-
#[AsCronTask(expression: '0 0 * * *', arguments: ['7', 8], schedule: 'dummy')]
16+
#[AsPeriodicTask(frequency: '1 hour', from: '09:00:00', until: '17:00:00', arguments: ['b' => 6, 'a' => '5'], schedule: 'dummy_task')]
17+
#[AsCronTask(expression: '0 0 * * *', arguments: ['7', 8], schedule: 'dummy_task')]
1818
public function attributesOnMethod(string $a, int $b): void
1919
{
2020
self::$calls[__FUNCTION__][] = [$a, $b];

‎src/Symfony/Component/Scheduler/DependencyInjection/AddScheduleMessengerPass.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,14 @@ public function process(ContainerBuilder $container): void
5959

6060
$taskArguments = [
6161
'$message' => $message,
62-
] + array_filter(match ($tagAttributes['trigger'] ?? throw new InvalidArgumentException("Tag 'scheduler.task' is missing attribute 'trigger' on service $serviceId.")) {
62+
] + array_filter(match ($tagAttributes['trigger'] ?? throw new InvalidArgumentException(sprintf('Tag "scheduler.task" is missing attribute "trigger" on service "%s".', $serviceId))) {
6363
'every' => [
64-
'$frequency' => $tagAttributes['frequency'] ?? throw new InvalidArgumentException("Tag 'scheduler.task' is missing attribute 'frequency' on service $serviceId."),
64+
'$frequency' => $tagAttributes['frequency'] ?? throw new InvalidArgumentException(sprintf('Tag "scheduler.task" is missing attribute "frequency" on service "%s".', $serviceId)),
6565
'$from' => $tagAttributes['from'] ?? null,
6666
'$until' => $tagAttributes['until'] ?? null,
6767
],
6868
'cron' => [
69-
'$expression' => $tagAttributes['expression'] ?? throw new InvalidArgumentException("Tag 'scheduler.task' is missing attribute 'expression' on service $serviceId."),
69+
'$expression' => $tagAttributes['expression'] ?? throw new InvalidArgumentException(sprintf('Tag "scheduler.task" is missing attribute "expression" on service "%s".', $serviceId)),
7070
8000 '$timezone' => $tagAttributes['timezone'] ?? null,
7171
],
7272
}, fn ($value) => null !== $value);

‎src/Symfony/Component/Scheduler/Tests/Command/DebugCommandTest.php

+10-10
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,11 @@ public function testExecuteWithScheduleWithoutTriggerShowingNoNextRunWithAllOpti
106106
"schedule_name\n".
107107
"-------------\n".
108108
"\n".
109-
" --------- ----------------------------------------------------------- ---------- \n".
110-
" Trigger Provider Next Run \n".
111-
" --------- ----------------------------------------------------------- ---------- \n".
112-
" test Symfony\Component\Scheduler\Trigger\StaticMessageProvider - \n".
113-
" --------- ----------------------------------------------------------- ---------- \n".
109+
" --------- ------------------------------- ---------- \n".
110+
" Trigger Provider Next Run \n".
111+
" --------- ------------------------------- ---------- \n" 8000 .
112+
" test stdClass(O:8:\"stdClass\":0:{}) - \n".
113+
" --------- ------------------------------- ---------- \n".
114114
"\n", $tester->getDisplay(true));
115115
}
116116

@@ -143,11 +143,11 @@ public function testExecuteWithSchedule()
143143
"schedule_name\n".
144144
"-------------\n".
145145
"\n".
146-
" ------------------------------- ----------------------------------------------------------- --------------------------------- \n".
147-
" Trigger Provider Next Run \n".
148-
" ------------------------------- ----------------------------------------------------------- --------------------------------- \n".
149-
" every first day of next month Symfony\\\\Component\\\\Scheduler\\\\Trigger\\\\StaticMessageProvider \w{3}, \d{1,2} \w{3} \d{4} \d{2}:\d{2}:\d{2} (\+|-)\d{4} \n".
150-
" ------------------------------- ----------------------------------------------------------- --------------------------------- \n".
146+
" ------------------------------- ------------------------------- --------------------------------- \n".
147+
" Trigger Provider Next Run \n".
148+
" ------------------------------- ------------------------------- --------------------------------- \n".
149+
" every first day of next month stdClass\(O:8:\"stdClass\":0:{}\) \w{3}, \d{1,2} \w{3} \d{4} \d{2}:\d{2}:\d{2} (\+|-)\d{4} \n".
150+
" ------------------------------- ------------------------------- --------------------------------- \n".
151151
"\n/", $tester->getDisplay(true));
152152
}
153153
}

0 commit comments

Comments
 (0)
0