10000 minor #45044 [Cache] fix tests with RedisArray (nicolas-grekas) · symfony/symfony@99b4885 · GitHub
[go: up one dir, main page]

Skip to content

Commit 99b4885

Browse files
minor #45044 [Cache] fix tests with RedisArray (nicolas-grekas)
This PR was merged into the 4.4 branch. Discussion ---------- [Cache] fix tests with RedisArray | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- c0879ec [Cache] fix tests with RedisArray
2 parents 3974dc1 + c0879ec commit 99b4885

File tree

3 files changed

+3
-2
lines changed
  • .github/workflows
  • src/Symfony/Component/Cache
    • < 8000 div class="PRIVATE_VisuallyHidden prc-TreeView-TreeViewVisuallyHidden-4-mPv" aria-hidden="true" id=":R1bflddabH1:">
      Tests/Adapter
  • Traits
  • 3 files changed

    +3
    -2
    lines changed

    .github/workflows/integration-tests.yml

    Lines changed: 1 addition & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -71,7 +71,7 @@ jobs:
    7171
    uses: shivammathur/setup-php@v2
    7272
    with:
    7373
    coverage: "none"
    74-
    extensions: "memcached,redis,xsl,ldap"
    74+
    extensions: "memcached,redis-5.3.4,xsl,ldap"
    7575
    ini-values: date.timezone=Europe/Paris,memory_limit=-1,default_socket_timeout=10,session.gc_probability=0,apc.enable_cli=1,zend.assertions=1
    7676
    php-version: "${{ matrix.php }}"
    7777

    src/Symfony/Component/Cache/Tests/Adapter/ProxyAdapterAndRedisAdapterTest.php

    Lines changed: 1 addition & 0 deletions
    Original file line numberDiff line numberDiff line change
    @@ -50,6 +50,7 @@ static function (CacheItem $item, $expiry) {
    5050
    );
    5151

    5252
    $cache = $this->createCachePool(1);
    53+
    $cache->clear();
    5354
    $value = rand();
    5455
    $item = $cache->getItem('foo');
    5556
    $setCacheItemExpiry($item, 0);

    src/Symfony/Component/Cache/Traits/RedisTrait.php

    Lines changed: 1 addition & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -185,7 +185,7 @@ public static function createConnection($dsn, array $options = [])
    185185

    186186
    $initializer = static function ($redis) use ($connect, $params, $dsn, $auth, $hosts, $tls) {
    187187
    $host = $hosts[0]['host'] ?? $hosts[0]['path'];
    188-
    $port = $hosts[0]['port'] ?? null;
    188+
    $port = $hosts[0]['port'] ?? 6379;
    189189

    190190
    if (isset($hosts[0]['host']) && $tls) {
    191191
    $host = 'tls://'.$host;

    0 commit comments

    Comments
     (0)
    0