bug #58952 [Cache] silence warnings issued by Redis Sentinel on connection issues (xabbuh)

nicolas-grekas · nicolas-grekas · commit 992a6a05fa47 · 2024-11-20T17:26:00.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [Cache] silence warnings issued by Redis Sentinel on connection issues | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT related to #58365 and #58818 see https://github.com/symfony/symfony/actions/runs/11936530431/job/33270392688#step:9:607 Commits ------- 97bdf94 silence warnings issued by Redis Sentinel on connection issues
diff --git a/src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
@@ -134,7 +134,7 @@ public function __construct(array $options, \Redis|Relay|\RedisCluster|null $red
                                     'readTimeout' => $options['read_timeout'],
                                 ];
 
-                                $sentinel = new \RedisSentinel($params);
+                                $sentinel = @new \RedisSentinel($params);
                             } else {
                                 $sentinel = @new $sentinelClass($host, $port, $options['timeout'], $options['persistent_id'], $options['retry_interval'], $options['read_timeout']);
                             }

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ public function __construct(array $options, \Redis\|Relay\|\RedisCluster\|null $red`
`134`	`134`	`'readTimeout' => $options['read_timeout'],`
`135`	`135`	`];`
`136`	`136`
`137`		`- $sentinel = new \RedisSentinel($params);`
	`137`	`+ $sentinel = @new \RedisSentinel($params);`
`138`	`138`	`} else {`
`139`	`139`	`$sentinel = @new $sentinelClass($host, $port, $options['timeout'], $options['persistent_id'], $options['retry_interval'], $options['read_timeout']);`
`140`	`140`	`}`