minor #42958 [DoctrineBridge] Replace string with FQCN resolution in EntityType (ker0x)

nicolas-grekas · nicolas-grekas · commit 98ed693f7328 · 2021-09-09T12:41:39.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [DoctrineBridge] Replace string with FQCN resolution in EntityType | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This minor PR simply replace the hard coded namespace of the QueryBuilder class with it's FQCN resolution Commits ------- 27b333a [DoctrineBridge] Replace string with FQCN resolution in EntityType
diff --git a/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php b/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php
@@ -32,15 +32,15 @@ public function configureOptions(OptionsResolver $resolver)
                 $queryBuilder = $queryBuilder($options['em']->getRepository($options['class']));
 
                 if (null !== $queryBuilder && !$queryBuilder instanceof QueryBuilder) {
-                    throw new UnexpectedTypeException($queryBuilder, 'Doctrine\ORM\QueryBuilder');
+                    throw new UnexpectedTypeException($queryBuilder, QueryBuilder::class);
                 }
             }
 
             return $queryBuilder;
         };
 
         $resolver->setNormalizer('query_builder', $queryBuilderNormalizer);
-        $resolver->setAllowedTypes('query_builder', ['null', 'callable', 'Doctrine\ORM\QueryBuilder']);
+        $resolver->setAllowedTypes('query_builder', ['null', 'callable', QueryBuilder::class]);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -32,15 +32,15 @@ public function configureOptions(OptionsResolver $resolver)`
`32`	`32`	`$queryBuilder = $queryBuilder($options['em']->getRepository($options['class']));`
`33`	`33`
`34`	`34`	`if (null !== $queryBuilder && !$queryBuilder instanceof QueryBuilder) {`
`35`		`- throw new UnexpectedTypeException($queryBuilder, 'Doctrine\ORM\QueryBuilder');`
	`35`	`+ throw new UnexpectedTypeException($queryBuilder, QueryBuilder::class);`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`return $queryBuilder;`
`40`	`40`	`};`
`41`	`41`
`42`	`42`	`$resolver->setNormalizer('query_builder', $queryBuilderNormalizer);`
`43`		`- $resolver->setAllowedTypes('query_builder', ['null', 'callable', 'Doctrine\ORM\QueryBuilder']);`
	`43`	`+ $resolver->setAllowedTypes('query_builder', ['null', 'callable', QueryBuilder::class]);`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`/**`