[Security] Display authenticators in the profiler even if they are all skipped

MatTheCat · MatTheCat · commit 971244120ac1 · 2024-06-11T12:23:38.000+02:00
diff --git a/src/Symfony/Component/Security/Http/Authentication/AuthenticatorManager.php b/src/Symfony/Component/Security/Http/Authentication/AuthenticatorManager.php
@@ -108,12 +108,13 @@ public function supports(Request $request): ?bool
             }
         }
 
+        $request->attributes->set('_security_skipped_authenticators', $skippedAuthenticators);
+
         if (!$authenticators) {
             return false;
         }
 
         $request->attributes->set('_security_authenticators', $authenticators);
-        $request->attributes->set('_security_skipped_authenticators', $skippedAuthenticators);
 
         return $lazy ? null : true;
     }
diff --git a/src/Symfony/Component/Security/Http/Authenticator/Debug/TraceableAuthenticatorManagerListener.php b/src/Symfony/Component/Security/Http/Authenticator/Debug/TraceableAuthenticatorManagerListener.php
@@ -36,16 +36,7 @@ public function __construct(
 
     public function supports(Request $request): ?bool
     {
-        return $this->authenticationManagerListener->supports($request);
-    }
-
-    public function authenticate(RequestEvent $event): void
-    {
-        $request = $event->getRequest();
-
-        if (!$authenticators = $request->attributes->get('_security_authenticators')) {
-            return;
-        }
+        $supports = $this->authenticationManagerListener->supports($request);
 
         foreach ($request->attributes->get('_security_skipped_authenticators') as $skippedAuthenticator) {
             $this->authenticatorsInfo[] = [
@@ -58,7 +49,18 @@ public function authenticate(RequestEvent $event): void
             ];
         }
 
-        foreach ($authenticators as $key => $authenticator) {
+        return $supports;
+    }
+
+    public function authenticate(RequestEvent $event): void
+    {
+        $request = $event->getRequest();
+
+        if (!$authenticators = $request->attributes->get('_security_authenticators')) {
+            return;
+        }
+
+        foreach ($request->attributes->get('_security_authenticators') as $key => $authenticator) {
             $authenticators[$key] = new TraceableAuthenticator($authenticator);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -108,12 +108,13 @@ public function supports(Request $request): ?bool`
`108`	`108`	`}`
`109`	`109`	`}`
`110`	`110`
	`111`	`+ $request->attributes->set('_security_skipped_authenticators', $skippedAuthenticators);`
	`112`	`+`
`111`	`113`	`if (!$authenticators) {`
`112`	`114`	`return false;`
`113`	`115`	`}`
`114`	`116`
`115`	`117`	`$request->attributes->set('_security_authenticators', $authenticators);`
`116`		`- $request->attributes->set('_security_skipped_authenticators', $skippedAuthenticators);`
`117`	`118`
`118`	`119`	`return $lazy ? null : true;`
`119`	`120`	`}`