[String] improve snake method for unicode string.

antten · antten · commit 9601b59af23b · 2024-07-20T18:26:51.000+02:00
Better management of uppercase string and removal of special end-of-line characters.
diff --git a/src/Symfony/Component/String/AbstractUnicodeString.php b/src/Symfony/Component/String/AbstractUnicodeString.php
@@ -366,10 +366,23 @@ public function reverse(): parent
 
     public function snake(): parent
     {
-        $str = $this->camel();
-        $str->string = mb_strtolower(preg_replace(['/(\p{Lu}+)(\p{Lu}\p{Ll})/u', '/([\p{Ll}0-9])(\p{Lu})/u'], '\1_\2', $str->string), 'UTF-8');
-
-        return $str;
+        $str = clone $this;
+        $matches = [];
+
+        preg_match_all(
+            '/([\p{Ll}0-9]+(?=\p{Lu}))|(\p{Lu}[\p{Ll}0-9]+)|(\p{Lu}+(?=\p{Lu}\p{Ll}))|((?<=\w)?[\p{Ll}\p{Lu}0-9]+(?=\w)?)/u',
+            $str,
+            $matches
+        );
+
+        $strings = array_map(
+            function (string $matchedString) {
+                return mb_strtolower($matchedString);
+            },
+            $matches[0] ?? []
+        );
+
+        return new static(implode('_', $strings));
     }
 
     public function title(bool $allWords = false): parent
