bug #43533 [Uid] fix 4 missing bits of entropy in UUIDv4 (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 95f5209c7e7d · 2021-10-16T14:15:22.000+02:00
This PR was merged into the 5.3 branch. Discussion ---------- [Uid] fix 4 missing bits of entropy in UUIDv4 | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #42787 | License | MIT | Doc PR | - Commits ------- 694b4fd [Uid] fix 4 missing bits of entropy in UUIDv4
diff --git a/src/Symfony/Component/Uid/UuidV4.php b/src/Symfony/Component/Uid/UuidV4.php
@@ -24,7 +24,7 @@ public function __construct(string $uuid = null)
     {
         if (null === $uuid) {
             $uuid = random_bytes(16);
-            $uuid[6] = $uuid[6] & "\x0F" | "\x4F";
+            $uuid[6] = $uuid[6] & "\x0F" | "\x40";
             $uuid[8] = $uuid[8] & "\x3F" | "\x80";
             $uuid = bin2hex($uuid);
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public function __construct(string $uuid = null)`
`24`	`24`	`{`
`25`	`25`	`if (null === $uuid) {`
`26`	`26`	`$uuid = random_bytes(16);`
`27`		`- $uuid[6] = $uuid[6] & "\x0F" \| "\x4F";`
	`27`	`+ $uuid[6] = $uuid[6] & "\x0F" \| "\x40";`
`28`	`28`	`$uuid[8] = $uuid[8] & "\x3F" \| "\x80";`
`29`	`29`	`$uuid = bin2hex($uuid);`
`30`	`30`