avoid setting BoundArgument twice in YamlFileLoader

przemyslaw-bogusz · przemyslaw-bogusz · commit 958ff16ba134 · 2019-01-20T15:10:20.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php
@@ -562,6 +562,9 @@ private function parseDefinition($id, $service, $file, array $defaults)
                 $bindings = array_merge($bindings, $this->resolveServices($service['bind'], $file));
                 $bindingType = $this->isLoadingInstanceof ? BoundArgument::INSTANCEOF_BIND : BoundArgument::SERVICE_BIND;
                 foreach ($bindings as $argument => $value) {
+                    if ($value instanceof BoundArgument) {
+                        continue;
+                    }
                     $bindings[$argument] = new BoundArgument($value, $bindingType, $file);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -562,6 +562,9 @@ private function parseDefinition($id, $service, $file, array $defaults)`
`562`	`562`	`$bindings = array_merge($bindings, $this->resolveServices($service['bind'], $file));`
`563`	`563`	`$bindingType = $this->isLoadingInstanceof ? BoundArgument::INSTANCEOF_BIND : BoundArgument::SERVICE_BIND;`
`564`	`564`	`foreach ($bindings as $argument => $value) {`
	`565`	`+ if ($value instanceof BoundArgument) {`
	`566`	`+ continue;`
	`567`	`+ }`
`565`	`568`	`$bindings[$argument] = new BoundArgument($value, $bindingType, $file);`
`566`	`569`	`}`
`567`	`570`	`}`