🔥 [53543] Doctrine transport should not be closeable - it reuses connection from the outside

andrew-demb · andrew-demb · commit 951f15fdf22c · 2025-02-27T19:04:50.000+01:00
diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
@@ -80,12 +80,6 @@ public function reset(): void
         $this->doMysqlCleanup = false;
     }
 
-    public function close(): void
-    {
-        $this->driverConnection->close();
-        $this->reset();
-    }
-
     public function getConfiguration(): array
     {
         return $this->configuration;
diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/DoctrineTransport.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/DoctrineTransport.php
@@ -15,7 +15,6 @@
 use Doctrine\DBAL\Schema\Schema;
 use Doctrine\DBAL\Schema\Table;
 use Symfony\Component\Messenger\Envelope;
-use Symfony\Component\Messenger\Transport\CloseableTransportInterface;
 use Symfony\Component\Messenger\Transport\Receiver\KeepaliveReceiverInterface;
 use Symfony\Component\Messenger\Transport\Receiver\ListableReceiverInterface;
 use Symfony\Component\Messenger\Transport\Receiver\MessageCountAwareInterface;
@@ -26,7 +25,7 @@
 /**
  * @author Vincent Touzet <vincent.touzet@gmail.com>
  */
-class DoctrineTransport implements TransportInterface, SetupableTransportInterface, CloseableTransportInterface, MessageCountAwareInterface, ListableReceiverInterface, KeepaliveReceiverInterface
+class DoctrineTransport implements TransportInterface, SetupableTransportInterface, MessageCountAwareInterface, ListableReceiverInterface, KeepaliveReceiverInterface
 {
     private DoctrineReceiver $receiver;
     private DoctrineSender $sender;
@@ -82,11 +81,6 @@ public function setup(): void
         $this->connection->setup();
     }
 
-    public function close(): void
-    {
-        $this->connection->close();
-    }
-
     /**
      * Adds the Table to the Schema if this transport uses this connection.
      */

Original file line number	Diff line number	Diff line change
`@@ -80,12 +80,6 @@ public function reset(): void`
`80`	`80`	`$this->doMysqlCleanup = false;`
`81`	`81`	`}`
`82`	`82`
`83`		`- public function close(): void`
`84`		`- {`
`85`		`- $this->driverConnection->close();`
`86`		`- $this->reset();`
`87`		`- }`
`88`		`-`
`89`	`83`	`public function getConfiguration(): array`
`90`	`84`	`{`
`91`	`85`	`return $this->configuration;`