minor #51581 [Mailer] bug - reset $code variable each iteration for prevent wrong exception codes (kgnblg)

fabpot · fabpot · commit 95153c4e59a0 · 2023-09-07T22:16:53.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- [Mailer] bug - reset $code variable each iteration for prevent wrong exception codes | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Follow up PR of #51568 to reset `$code` variable for each iteration to have correct `TransportException` code. (Note: This bug does not exist in version 5.4) Commits ------- ce4bc8c [mailer] reset $code variable each iteration for prevent wrong codes to be used
diff --git a/src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransport.php b/src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransport.php
@@ -193,6 +193,7 @@ private function handleAuth(array $modes): void
                 continue;
             }
 
+            $code = null;
             $authNames[] = $authenticator->getAuthKeyword();
             try {
                 $authenticator->authenticate($this);

Original file line number	Diff line number	Diff line change
`@@ -193,6 +193,7 @@ private function handleAuth(array $modes): void`
`193`	`193`	`continue;`
`194`	`194`	`}`
`195`	`195`
	`196`	`+ $code = null;`
`196`	`197`	`$authNames[] = $authenticator->getAuthKeyword();`
`197`	`198`	`try {`
`198`	`199`	`$authenticator->authenticate($this);`