bug #24192 [PhpUnitBridge] do not require an error context (xabbuh)

nicolas-grekas · nicolas-grekas · commit 949b17a2c794 · 2017-09-19T11:20:34.000+02:00
This PR was merged into the 3.3 branch. Discussion ---------- [PhpUnitBridge] do not require an error context | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The error context argument of an error handler is deprecated as of PHP 7.2. Requiring it in the error handler of the SymfonyTestsListenerTrait will make error handlers fail that are executed when running PHPUnit tests and forward the error handling to the previously registered error handler. Commits ------- 10ce932 [PhpUnitBridge] do not require an error context
diff --git a/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php b/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
@@ -303,7 +303,7 @@ public function endTest($test, $time)
         }
     }
 
-    public function handleError($type, $msg, $file, $line, $context)
+    public function handleError($type, $msg, $file, $line, $context = array())
     {
         if (E_USER_DEPRECATED !== $type && E_DEPRECATED !== $type) {
             $h = $this->previousErrorHandler;

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ public function endTest($test, $time)`
`303`	`303`	`}`
`304`	`304`	`}`
`305`	`305`
`306`		`- public function handleError($type, $msg, $file, $line, $context)`
	`306`	`+ public function handleError($type, $msg, $file, $line, $context = array())`
`307`	`307`	`{`
`308`	`308`	`if (E_USER_DEPRECATED !== $type && E_DEPRECATED !== $type) {`
`309`	`309`	`$h = $this->previousErrorHandler;`