merged branch entering/browser-kit-beautify-code (PR #8432)

fabpot · fabpot · commit 92c30b913b23 · 2013-07-07T17:48:29.000+02:00
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #8432). Discussion ---------- [BrowserKit] CookieJar remove unneeded var, Client remove unneeded else | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 10c6799 [BrowserKit] CookieJar remove unneeded var, Client remove unneeded else
diff --git a/src/Symfony/Component/BrowserKit/CookieJar.php b/src/Symfony/Component/BrowserKit/CookieJar.php
@@ -59,7 +59,7 @@ public function get($name, $path = '/', $domain = null)
         }
 
         // avoid relying on this behavior that is mainly here for BC reasons
-        foreach ($this->cookieJar as $domain => $cookies) {
+        foreach ($this->cookieJar as $cookies) {
             if (isset($cookies[$path][$name])) {
                 return $cookies[$path][$name];
             }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public function get($name, $path = '/', $domain = null)`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`// avoid relying on this behavior that is mainly here for BC reasons`
`62`		`- foreach ($this->cookieJar as $domain => $cookies) {`
	`62`	`+ foreach ($this->cookieJar as $cookies) {`
`63`	`63`	`if (isset($cookies[$path][$name])) {`
`64`	`64`	`return $cookies[$path][$name];`
`65`	`65`	`}`