last improvements

yceruto · yceruto · commit 91da8a710982 · 2023-10-19T14:08:11.000-04:00
diff --git a/src/Symfony/Component/Validator/Constraints/GroupSequenceProvider.php b/src/Symfony/Component/Validator/Constraints/GroupSequenceProvider.php
@@ -11,22 +11,25 @@
 
 namespace Symfony\Component\Validator\Constraints;
 
+use Doctrine\Common\Annotations\Annotation\NamedArgumentConstructor;
+use Symfony\Component\Validator\Attribute\HasNamedArguments;
+
 /**
  * Attribute to define a group sequence provider.
  *
  * @Annotation
  *
+ * @NamedArgumentConstructor
+ *
  * @Target({"CLASS", "ANNOTATION"})
  *
  * @author Bernhard Schussek <bschussek@gmail.com>
  */
 #[\Attribute(\Attribute::TARGET_CLASS)]
 class GroupSequenceProvider
 {
-    public ?string $provider = null;
-
-    public function __construct(array $options = [], string $provider = null)
+    #[HasNamedArguments]
+    public function __construct(public ?string $provider = null)
     {
-        $this->provider = $options['provider'] ?? $provider;
     }
 }
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/GroupSequenceProviderTest.php b/src/Symfony/Component/Validator/Tests/Constraints/GroupSequenceProviderTest.php
@@ -17,13 +17,6 @@
 
 class GroupSequenceProviderTest extends TestCase
 {
-    public function testCreate()
-    {
-        $sequence = new GroupSequenceProvider(['provider' => DummyGroupProvider::class]);
-
-        $this->assertSame(DummyGroupProvider::class, $sequence->provider);
-    }
-
     public function testCreateAttributeStyle()
     {
         $sequence = new GroupSequenceProvider(provider: DummyGroupProvider::class);

Original file line number	Diff line number	Diff line change
`@@ -11,22 +11,25 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\Validator\Constraints;`
`13`	`13`
	`14`	`+use Doctrine\Common\Annotations\Annotation\NamedArgumentConstructor;`
	`15`	`+use Symfony\Component\Validator\Attribute\HasNamedArguments;`
	`16`	`+`
`14`	`17`	`/**`
`15`	`18`	`* Attribute to define a group sequence provider.`
`16`	`19`	`*`
`17`	`20`	`* @Annotation`
`18`	`21`	`*`
	`22`	`+ * @NamedArgumentConstructor`
	`23`	`+ *`
`19`	`24`	`* @Target({"CLASS", "ANNOTATION"})`
`20`	`25`	`*`
`21`	`26`	`* @author Bernhard Schussek <bschussek@gmail.com>`
`22`	`27`	`*/`
`23`	`28`	`#[\Attribute(\Attribute::TARGET_CLASS)]`
`24`	`29`	`class GroupSequenceProvider`
`25`	`30`	`{`
`26`		`- public ?string $provider = null;`
`27`		`-`
`28`		`- public function __construct(array $options = [], string $provider = null)`
	`31`	`+ #[HasNamedArguments]`
	`32`	`+ public function __construct(public ?string $provider = null)`
`29`	`33`	`{`
`30`		`- $this->provider = $options['provider'] ?? $provider;`
`31`	`34`	`}`
`32`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,13 +17,6 @@`
`17`	`17`
`18`	`18`	`class GroupSequenceProviderTest extends TestCase`
`19`	`19`	`{`
`20`		`- public function testCreate()`
`21`		`- {`
`22`		`- $sequence = new GroupSequenceProvider(['provider' => DummyGroupProvider::class]);`
`23`		`-`
`24`		`- $this->assertSame(DummyGroupProvider::class, $sequence->provider);`
`25`		`- }`
`26`		`-`
`27`	`20`	`public function testCreateAttributeStyle()`
`28`	`21`	`{`
`29`	`22`	`$sequence = new GroupSequenceProvider(provider: DummyGroupProvider::class);`