Disable PHPUnit result cache on the CI

nicolas-grekas · nicolas-grekas · commit 912d7db7dd63 · 2019-08-10T20:59:22.000+02:00
diff --git a/.appveyor.yml b/.appveyor.yml
@@ -13,6 +13,7 @@ init:
     - SET "SYMFONY_REQUIRE=>=3.4"
     - SET ANSICON=121x90 (121x90)
     - SET SYMFONY_PHPUNIT_VERSION=4.8
+    - SET SYMFONY_PHPUNIT_DISABLE_RESULT_CACHE=1
     - REG ADD "HKEY_CURRENT_USER\Software\Microsoft\Command Processor" /v DelayedExpansion /t REG_DWORD /d 1 /f
 
 install:
diff --git a/.travis.yml b/.travis.yml
@@ -18,6 +18,7 @@ env:
         - MIN_PHP=5.5.9
         - SYMFONY_PROCESS_PHP_TEST_BINARY=~/.phpenv/versions/5.6/bin/php
         - SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT=1
+        - SYMFONY_PHPUNIT_DISABLE_RESULT_CACHE=1
 
 matrix:
     include:
diff --git a/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit b/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit
@@ -133,6 +133,14 @@ EOPHP
 global $argv, $argc;
 $argv = isset($_SERVER['argv']) ? $_SERVER['argv'] : array();
 $argc = isset($_SERVER['argc']) ? $_SERVER['argc'] : 0;
+
+if ($PHPUNIT_VERSION < 8.0) {
+    $argv = array_filter($argv, function ($v) use (&$argc) { if ('--do-not-cache-result' !== $v) return true; --$argc; });
+} elseif (filter_var(getenv('SYMFONY_PHPUNIT_DISABLE_RESULT_CACHE'), FILTER_VALIDATE_BOOLEAN)) {
+    $argv[] = '--do-not-cache-result';
+    ++$argc;
+}
+
 $components = array();
 $cmd = array_map('escapeshellarg', $argv);
 $exit = 0;
diff --git a/src/Symfony/Component/Config/Definition/BaseNode.php b/src/Symfony/Component/Config/Definition/BaseNode.php
@@ -280,9 +280,9 @@ final public function normalize($value)
     /**
      * Normalizes the value before any other normalization is applied.
      *
-     * @param $value
+     * @param mixed $value
      *
-     * @return The normalized array value
+     * @return mixed The normalized array value
      */
     protected function preNormalize($value)
     {

Original file line number	Diff line number	Diff line change
`@@ -280,9 +280,9 @@ final public function normalize($value)`
`280`	`280`	`/**`
`281`	`281`	`* Normalizes the value before any other normalization is applied.`
`282`	`282`	`*`
`283`		`- * @param $value`
	`283`	`+ * @param mixed $value`
`284`	`284`	`*`
`285`		`- * @return The normalized array value`
	`285`	`+ * @return mixed The normalized array value`
`286`	`286`	`*/`
`287`	`287`	`protected function preNormalize($value)`
`288`	`288`	`{`