minor #18299 [Form] Remove unused legacy code in ChoiceType (HeahDude)

Tobion · Tobion · commit 90ece1cf5ca2 · 2016-03-25T02:25:21.000+01:00
This PR was merged into the 3.0 branch. Discussion ---------- [Form] Remove unused legacy code in `ChoiceType` | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | - Commits ------- 8af78e9 [Form] Remove unused legacy code in `ChoiceType`
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php b/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php
@@ -357,21 +357,6 @@ public function getBlockPrefix()
         return 'choice';
     }
 
-    private static function flipRecursive($choices, &$output = array())
-    {
-        foreach ($choices as $key => $value) {
-            if (is_array($value)) {
-                $output[$key] = array();
-                self::flipRecursive($value, $output[$key]);
-                continue;
-            }
-
-            $output[$value] = $key;
-        }
-
-        return $output;
-    }
-
     /**
      * Adds the sub fields for an expanded choice field.
      *
@@ -447,9 +432,7 @@ private function createChoiceListView(ChoiceListInterface $choiceList, array $op
         // If no explicit grouping information is given, use the structural
         // information from the "choices" option for creating groups
         if (!$options['group_by'] && $options['choices']) {
-            $options['group_by'] = !$options['choices_as_values']
-                ? self::flipRecursive($options['choices'])
-                : $options['choices'];
+            $options['group_by'] = $options['choices'];
         }
 
         return $this->choiceListFactory->createView(
