[HttpClient] fix dealing with informational response

nicolas-grekas · nicolas-grekas · commit 9068aa48e24b · 2020-05-08T22:52:14.000+02:00
diff --git a/src/Symfony/Component/HttpClient/Response/AmpResponse.php b/src/Symfony/Component/HttpClient/Response/AmpResponse.php
@@ -200,7 +200,7 @@ private static function generateResponse(Request $request, AmpClientState $multi
 
             $options = null;
 
-            $activity[$id] = [new FirstChunk()];
+            $activity[$id][] = new FirstChunk();
 
             if ('HEAD' === $response->getRequest()->getMethod() || \in_array($info['http_code'], [204, 304], true)) {
                 $activity[$id][] = null;
diff --git a/src/Symfony/Component/HttpClient/Tests/AmpHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/AmpHttpClientTest.php
@@ -25,13 +25,4 @@ public function testProxy()
     {
         $this->markTestSkipped('A real proxy server would be needed.');
     }
-
-    public function testInformationalResponseStream()
-    {
-        if (getenv('TRAVIS_PULL_REQUEST')) {
-            $this->markTestIncomplete('This test always fails on Travis.');
-        }
-
-        parent::testInformationalResponseStream();
-    }
 }

Original file line number	Diff line number	Diff line change
`@@ -25,13 +25,4 @@ public function testProxy()`
`25`	`25`	`{`
`26`	`26`	`$this->markTestSkipped('A real proxy server would be needed.');`
`27`	`27`	`}`
`28`		`-`
`29`		`- public function testInformationalResponseStream()`
`30`		`- {`
`31`		`- if (getenv('TRAVIS_PULL_REQUEST')) {`
`32`		`- $this->markTestIncomplete('This test always fails on Travis.');`
`33`		`- }`
`34`		`-`
`35`		`- parent::testInformationalResponseStream();`
`36`		`- }`
`37`	`28`	`}`