minor #39561 [Serializer] Fix DenormalizableInterface::denormalize() return type declaration in docblock (jeroennoten)

derrabus · derrabus · commit 8f7a8d345a1a · 2020-12-20T14:32:21.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Serializer] Fix DenormalizableInterface::denormalize() return type declaration in docblock | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N.A. | License | MIT | Doc PR | N.A. DenormalizableInterface::denormalize() should not return anything, so the `@return` declaration should be removed. If you look at the usage in `CustomNormalizer::denormalize()`, it becomes clear that this method shouldn't return anything: ```php public function denormalize($data, $type, $format = null, array $context = []) { $object = $this->extractObjectToPopulate($type, $context) ?: new $type(); $object->denormalize($this->serializer, $data, $format, $context); return $object; } ``` Commits ------- 00c90ae [Serializer] Fix DenormalizableInterface::denormalize() return type declaration in docblock
diff --git a/src/Symfony/Component/Serializer/Normalizer/DenormalizableInterface.php b/src/Symfony/Component/Serializer/Normalizer/DenormalizableInterface.php
@@ -33,8 +33,6 @@ interface DenormalizableInterface
      * @param string|null                 $format       The format is optionally given to be able to denormalize
      *                                                  differently based on different input formats
      * @param array                       $context      Options for denormalizing
-     *
-     * @return object|object[]
      */
     public function denormalize(DenormalizerInterface $denormalizer, $data, $format = null, array $context = []);
 }

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,6 @@ interface DenormalizableInterface`
`33`	`33`	`* @param string\|null $format The format is optionally given to be able to denormalize`
`34`	`34`	`* differently based on different input formats`
`35`	`35`	`* @param array $context Options for denormalizing`
`36`		`- *`
`37`		`- * @return object\|object[]`
`38`	`36`	`*/`
`39`	`37`	`public function denormalize(DenormalizerInterface $denormalizer, $data, $format = null, array $context = []);`
`40`	`38`	`}`