minor #35898 [DI] Clarified deprecation for TypedReference in 4.4 (linaori)

fabpot · fabpot · commit 8ed2e66de469 · 2020-02-29T10:50:10.000+01:00
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [DI] Clarified deprecation for TypedReference in 4.4 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no  | Deprecations? | no  | Tickets | Fix #35752  | License | MIT | Doc PR |~  Changes the deprecation message to indicate the argument has been removed and how to fix it. Commits ------- 1c70048 [DI] Clarified deprecation for TypedReference in 4.4
diff --git a/src/Symfony/Component/DependencyInjection/TypedReference.php b/src/Symfony/Component/DependencyInjection/TypedReference.php
@@ -31,7 +31,7 @@ class TypedReference extends Reference
     public function __construct(string $id, string $type, $invalidBehavior = ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE, $name = null)
     {
         if (\is_string($invalidBehavior ?? '') || \is_int($name)) {
-            @trigger_error(sprintf('The $requiringClass argument of "%s()" is deprecated since Symfony 4.1.', __METHOD__), E_USER_DEPRECATED);
+            @trigger_error(sprintf('Passing the $requiringClass as 3rd argument for "%s()" is deprecated since Symfony 4.1. It should be removed, moving all following arguments 1 to the left.', __METHOD__), E_USER_DEPRECATED);
 
             $this->requiringClass = $invalidBehavior;
             $invalidBehavior = 3 < \func_num_args() ? func_get_arg(3) : ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE;

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class TypedReference extends Reference`
`31`	`31`	`public function __construct(string $id, string $type, $invalidBehavior = ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE, $name = null)`
`32`	`32`	`{`
`33`	`33`	`if (\is_string($invalidBehavior ?? '') \|\| \is_int($name)) {`
`34`		`- @trigger_error(sprintf('The $requiringClass argument of "%s()" is deprecated since Symfony 4.1.', __METHOD__), E_USER_DEPRECATED);`
	`34`	`+ @trigger_error(sprintf('Passing the $requiringClass as 3rd argument for "%s()" is deprecated since Symfony 4.1. It should be removed, moving all following arguments 1 to the left.', __METHOD__), E_USER_DEPRECATED);`
`35`	`35`
`36`	`36`	`$this->requiringClass = $invalidBehavior;`
`37`	`37`	`$invalidBehavior = 3 < \func_num_args() ? func_get_arg(3) : ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE;`