bug #38091 [DI] fix ContainerBuilder on PHP8 (nicolas-grekas)

fabpot · fabpot · commit 8e34978e4e2c · 2020-09-07T14:09:53.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [DI] fix ContainerBuilder on PHP8 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #38089 | License | MIT | Doc PR | - Commits ------- a3275a7 [DI] fix ContainerBuilder on PHP8
diff --git a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php
@@ -1173,7 +1173,7 @@ private function createService(Definition $definition, array &$inlineServices, $
         } else {
             $r = new \ReflectionClass($class = $parameterBag->resolveValue($definition->getClass()));
 
-            $service = null === $r->getConstructor() ? $r->newInstance() : $r->newInstanceArgs($arguments);
+            $service = null === $r->getConstructor() ? $r->newInstance() : $r->newInstanceArgs(array_values($arguments));
             // don't trigger deprecations for internal uses
             // @deprecated since version 3.3, to be removed in 4.0 along with the deprecated class
             $deprecationAllowlist = ['event_dispatcher' => ContainerAwareEventDispatcher::class];
