minor #59451 [AssetMapper] skip test if not supported compressors are available (xabbuh)

chalasr · chalasr · commit 8dc32f757821 · 2025-01-09T13:14:53.000+01:00
This PR was merged into the 7.3 branch. Discussion ---------- [AssetMapper] skip test if not supported compressors are available | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 8208c75 skip test if not supported compressors are available
diff --git a/src/Symfony/Component/AssetMapper/Path/LocalPublicAssetsFilesystem.php b/src/Symfony/Component/AssetMapper/Path/LocalPublicAssetsFilesystem.php
@@ -50,7 +50,7 @@ public function getDestinationPath(): string
         return $this->publicDir;
     }
 
-    private function compress($targetPath): void
+    private function compress(string $targetPath): void
     {
         foreach ($this->extensionsToCompress as $ext) {
             if (!str_ends_with($targetPath, ".$ext")) {
diff --git a/src/Symfony/Component/AssetMapper/Tests/Compressor/ChainCompressorTest.php b/src/Symfony/Component/AssetMapper/Tests/Compressor/ChainCompressorTest.php
@@ -14,6 +14,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\AssetMapper\Compressor\BrotliCompressor;
 use Symfony\Component\AssetMapper\Compressor\ChainCompressor;
+use Symfony\Component\AssetMapper\Compressor\GzipCompressor;
 use Symfony\Component\AssetMapper\Compressor\ZstandardCompressor;
 use Symfony\Component\Filesystem\Filesystem;
 
@@ -41,14 +42,21 @@ protected function tearDown(): void
 
     public function testCompress()
     {
-        $extensions = ['gz'];
+        $extensions = [];
+        if (null === (new GzipCompressor())->getUnsupportedReason()) {
+            $extensions[] = 'gz';
+        }
         if (null === (new BrotliCompressor())->getUnsupportedReason()) {
             $extensions[] = 'br';
         }
         if (null === (new ZstandardCompressor())->getUnsupportedReason()) {
             $extensions[] = 'zst';
         }
 
+        if (!$extensions) {
+            $this->markTestSkipped('No supported compressors available.');
+        }
+
         $this->filesystem->dumpFile(self::WRITABLE_ROOT.'/foo/bar.js', 'foobar');
 
         (new ChainCompressor())->compress(self::WRITABLE_ROOT.'/foo/bar.js');

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function getDestinationPath(): string`
`50`	`50`	`return $this->publicDir;`
`51`	`51`	`}`
`52`	`52`
`53`		`- private function compress($targetPath): void`
	`53`	`+ private function compress(string $targetPath): void`
`54`	`54`	`{`
`55`	`55`	`foreach ($this->extensionsToCompress as $ext) {`
`56`	`56`	`if (!str_ends_with($targetPath, ".$ext")) {`