Merge branch '2.7' into 2.8

nicolas-grekas · nicolas-grekas · commit 8ca614dbc99f · 2016-05-06T11:32:10.000+02:00
* 2.7:
  top-level anonymous services must be public
diff --git a/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
@@ -315,6 +315,10 @@ private function processAnonymousServices(\DOMDocument $xml, $file)
                 if ($services = $this->getChildren($node, 'service')) {
                     $definitions[$id] = array($services[0], $file, false);
                     $services[0]->setAttribute('id', $id);
+
+                    // anonymous services are always private
+                    // we could not use the constant false here, because of XML parsing
+                    $services[0]->setAttribute('public', 'false');
                 }
             }
         }
@@ -334,9 +338,6 @@ private function processAnonymousServices(\DOMDocument $xml, $file)
         foreach ($definitions as $id => $def) {
             list($domElement, $file, $wild) = $def;
 
-            // anonymous services are always private
-            // we could not use the constant false here, because of XML parsing
-            $domElement->setAttribute('public', 'false');
 
             if (null !== $definition = $this->parseDefinition($domElement, $file)) {
                 $this->container->setDefinition($id, $definition);
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php
@@ -200,7 +200,7 @@ public function testLoadAnonymousServices()
             $service = $container->getDefinition($id);
         }
         $this->assertEquals('BizClass', $service->getClass(), '->load() uses the same configuration as for the anonymous ones');
-        $this->assertFalse($service->isPublic());
+        $this->assertTrue($service->isPublic());
 
         // anonymous services are shared when using decoration definitions
         $container->compile();

Original file line number	Diff line number	Diff line change
`@@ -315,6 +315,10 @@ private function processAnonymousServices(\DOMDocument $xml, $file)`
`315`	`315`	`if ($services = $this->getChildren($node, 'service')) {`
`316`	`316`	`$definitions[$id] = array($services[0], $file, false);`
`317`	`317`	`$services[0]->setAttribute('id', $id);`
	`318`	`+`
	`319`	`+ // anonymous services are always private`
	`320`	`+ // we could not use the constant false here, because of XML parsing`
	`321`	`+ $services[0]->setAttribute('public', 'false');`
`318`	`322`	`}`
`319`	`323`	`}`
`320`	`324`	`}`
`@@ -334,9 +338,6 @@ private function processAnonymousServices(\DOMDocument $xml, $file)`
`334`	`338`	`foreach ($definitions as $id => $def) {`
`335`	`339`	`list($domElement, $file, $wild) = $def;`
`336`	`340`
`337`		`- // anonymous services are always private`
`338`		`- // we could not use the constant false here, because of XML parsing`
`339`		`- $domElement->setAttribute('public', 'false');`
`340`	`341`
`341`	`342`	`if (null !== $definition = $this->parseDefinition($domElement, $file)) {`
`342`	`343`	`$this->container->setDefinition($id, $definition);`
Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ public function testLoadAnonymousServices()`
`200`	`200`	`$service = $container->getDefinition($id);`
`201`	`201`	`}`
`202`	`202`	`$this->assertEquals('BizClass', $service->getClass(), '->load() uses the same configuration as for the anonymous ones');`
`203`		`- $this->assertFalse($service->isPublic());`
	`203`	`+ $this->assertTrue($service->isPublic());`
`204`	`204`
`205`	`205`	`// anonymous services are shared when using decoration definitions`
`206`	`206`	`$container->compile();`