[VarDumper] fix side-effect by not using mt_rand()

nicolas-grekas · nicolas-grekas · commit 8c85f91b9c3a · 2020-03-17T23:27:36.000+01:00
diff --git a/src/Symfony/Component/VarDumper/Cloner/VarCloner.php b/src/Symfony/Component/VarDumper/Cloner/VarCloner.php
@@ -48,8 +48,8 @@ protected function doClone($var)
                                         // or null if the original value is used directly
 
         if (!self::$hashMask) {
-            self::$gid = uniqid(mt_rand(), true); // Unique string used to detect the special $GLOBALS variable
             self::initHashMask();
+            self::$gid = md5(dechex(self::$hashMask)); // Unique string used to detect the special $GLOBALS variable
         }
         $gid = self::$gid;
         $hashMask = self::$hashMask;

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,8 @@ protected function doClone($var)`
`48`	`48`	`// or null if the original value is used directly`
`49`	`49`
`50`	`50`	`if (!self::$hashMask) {`
`51`		`- self::$gid = uniqid(mt_rand(), true); // Unique string used to detect the special $GLOBALS variable`
`52`	`51`	`self::initHashMask();`
	`52`	`+ self::$gid = md5(dechex(self::$hashMask)); // Unique string used to detect the special $GLOBALS variable`
`53`	`53`	`}`
`54`	`54`	`$gid = self::$gid;`
`55`	`55`	`$hashMask = self::$hashMask;`