Add functional test for user authorization checker

natewiebe13 · natewiebe13 · commit 8c0fc43ef29b · 2022-11-08T10:53:31.000-05:00
diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/Functional/SecurityTest.php b/src/Symfony/Bundle/SecurityBundle/Tests/Functional/SecurityTest.php
@@ -47,6 +47,24 @@ public function testServiceIsFunctional()
         $this->assertSame('main', $firewallConfig->getName());
     }
 
+    public function testUserAuthorizationChecker()
+    {
+        $kernel = self::createKernel(['test_case' => 'SecurityHelper', 'root_config' => 'config.yml']);
+        $kernel->boot();
+        $container = $kernel->getContainer();
+
+        $loggedInUser = new InMemoryUser('foo', 'pass', ['ROLE_USER', 'ROLE_FOO']);
+        $offlineUser = new InMemoryUser('bar', 'pass', ['ROLE_USER', 'ROLE_BAR']);
+        $token = new UsernamePasswordToken($loggedInUser, 'provider', $loggedInUser->getRoles());
+        $container->get('functional.test.security.token_storage')->setToken($token);
+
+        $security = $container->get('functional_test.security.helper');
+        $this->assertTrue($security->isGranted('ROLE_FOO'));
+        $this->assertFalse($security->isGranted('ROLE_BAR'));
+        $this->assertTrue($security->userIsGranted($offlineUser, 'ROLE_BAR'));
+        $this->assertFalse($security->userIsGranted($offlineUser, 'ROLE_FOO'));
+    }
+
     /**
      * @dataProvider userWillBeMarkedAsChangedIfRolesHasChangedProvider
      */
diff --git a/src/Symfony/Component/Security/Core/Security.php b/src/Symfony/Component/Security/Core/Security.php
@@ -86,7 +86,7 @@ public function isGranted(mixed $attributes, mixed $subject = null): bool
     public function userIsGranted(UserInterface $user, mixed $attributes, mixed $subject = null): bool
     {
         return $this->container->get('security.user_authorization_checker')
-            ->isGranted($user, $attributes, $subject);
+            ->userIsGranted($user, $attributes, $subject);
     }
 
     public function getToken(): ?TokenInterface

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public function isGranted(mixed $attributes, mixed $subject = null): bool`
`86`	`86`	`public function userIsGranted(UserInterface $user, mixed $attributes, mixed $subject = null): bool`
`87`	`87`	`{`
`88`	`88`	`return $this->container->get('security.user_authorization_checker')`
`89`		`- ->isGranted($user, $attributes, $subject);`
	`89`	`+ ->userIsGranted($user, $attributes, $subject);`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`public function getToken(): ?TokenInterface`