feature #28954 [Debug] Mark ErrorHandler and ExceptionHandler classes as final (fancyweb)

nicolas-grekas · nicolas-grekas · commit 8aee36dbd5de · 2018-12-01T11:04:56.000+01:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [Debug] Mark ErrorHandler and ExceptionHandler classes as final | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | not yet | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The goal of marking this method final is to be able to change the argument signature to `\Throwable` in Symfony 5.0 We will then be able to convert the incoming `\Throwable` to `\ErrorException` thanks to the `FatalThrowableError` class. The use case is when you use the `ExceptionHandler::register()` method of the `Debug` component with a custom `set_error_handler()` that don't handle this conversion. This is for example the case of the `Drupal` one. Commits ------- 2a4e2e6 [Debug] Mark the ErrorHandler and ExceptionHandler classes as final
diff --git a/src/Symfony/Component/Debug/CHANGELOG.md b/src/Symfony/Component/Debug/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+4.3.0
+-----
+
+* made the `ErrorHandler` and `ExceptionHandler` classes final
+
 4.0.0
 -----
 
diff --git a/src/Symfony/Component/Debug/ErrorHandler.php b/src/Symfony/Component/Debug/ErrorHandler.php
@@ -45,6 +45,8 @@
  *
  * @author Nicolas Grekas <p@tchwork.com>
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
+ *
+ * @final since Symfony 4.3
  */
 class ErrorHandler
 {
diff --git a/src/Symfony/Component/Debug/ExceptionHandler.php b/src/Symfony/Component/Debug/ExceptionHandler.php
@@ -26,6 +26,8 @@
  *
  * @author Fabien Potencier <fabien@symfony.com>
  * @author Nicolas Grekas <p@tchwork.com>
+ *
+ * @final since Symfony 4.3
  */
 class ExceptionHandler
 {

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,8 @@`
`45`	`45`	`*`
`46`	`46`	`* @author Nicolas Grekas <p@tchwork.com>`
`47`	`47`	`* @author Grégoire Pineau <lyrixx@lyrixx.info>`
	`48`	`+ *`
	`49`	`+ * @final since Symfony 4.3`
`48`	`50`	`*/`
`49`	`51`	`class ErrorHandler`
`50`	`52`	`{`
Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,8 @@`
`26`	`26`	`*`
`27`	`27`	`* @author Fabien Potencier <fabien@symfony.com>`
`28`	`28`	`* @author Nicolas Grekas <p@tchwork.com>`
	`29`	`+ *`
	`30`	`+ * @final since Symfony 4.3`
`29`	`31`	`*/`
`30`	`32`	`class ExceptionHandler`
`31`	`33`	`{`