bug #60826 [DependencyInjection] Fix inlining when public services are involved (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 8a846a9810ad · 2025-06-19T08:26:09.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [DependencyInjection] Fix inlining when public services are involved | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54294, fix #58087 | License | MIT I can't come up with a simple reproducer that'd fit in a test case 😞 Commits ------- b982f6e [DependencyInjection] Fix inlining when public services are involved
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php
@@ -73,6 +73,9 @@ public function process(ContainerBuilder $container)
                     if (!$this->graph->hasNode($id)) {
                         continue;
                     }
+                    if ($definition->isPublic()) {
+                        $this->connectedIds[$id] = true;
+                    }
                     foreach ($this->graph->getNode($id)->getOutEdges() as $edge) {
                         if (isset($notInlinedIds[$edge->getSourceNode()->getId()])) {
                             $this->currentId = $id;
@@ -189,17 +192,13 @@ private function isInlineableDefinition(string $id, Definition $definition): boo
             return true;
         }
 
-        if ($definition->isPublic()) {
+        if ($definition->isPublic()
+            || $this->currentId === $id
+            || !$this->graph->hasNode($id)
+        ) {
             return false;
         }
 
-        if (!$this->graph->hasNode($id)) {
-            return true;
-        }
-
-        if ($this->currentId === $id) {
-            return false;
-        }
         $this->connectedIds[$id] = true;
 
         $srcIds = [];
