8000 [Process] Fix escaping /X arguments on Windows · symfony/symfony@8a53c20 · GitHub
[go: up one dir, main page]
Skip to content

Commit 8a53c20

Browse files
nicolas-grekasnicolas-grekas
committed
[Process] Fix escaping /X arguments on Windows
1 parent 97aedb3 commit 8a53c20

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

‎src/Symfony/Component/Process/Process.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1638,7 +1638,7 @@ private function escapeArgument(?string $argument): string
16381638
if (str_contains($argument, "\0")) {
16391639
$argument = str_replace("\0", '?', $argument);
16401640
}
1641-
if (!preg_match('/[\/()%!^"<>&|\s]/', $argument)) {
1641+
if (!preg_match('/[()%!^"<>&|\s]/', $argument)) {
16421642
return $argument;
16431643
}
16441644
$argument = preg_replace('/(\\\\+)$/', '$1$1', $argument);

‎src/Symfony/Component/Process/Tests/ProcessTest.php‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1426,6 +1426,11 @@ public function testGetCommandLine()
14261426

14271427
$expected = '\\' === \DIRECTORY_SEPARATOR ? '"/usr/bin/php"' : "'/usr/bin/php'";
14281428
$this->assertSame($expected, $p->getCommandLine());
1429+
1430+
$p = new Process(['cd', '/d']);
1431+
1432+
$expected = '\\' === \DIRECTORY_SEPARATOR ? 'cd /d' : "'cd' '/d'";
1433+
$this->assertSame($expected, $p->getCommandLine());
14291434
}
14301435

14311436
/**

0 commit comments

Comments
 (0)
0