bug #42690 [Notifier] Firebase error handling (mishaklomp)

fabpot · fabpot · commit 8a33e0576adf · 2021-08-23T16:17:52.000+02:00
This PR was merged into the 5.3 branch. Discussion ---------- [Notifier] Firebase error handling | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #42211 | License | MIT | Doc PR | symfony/symfony-docs I found a bug in the Firebase error handling, resulting in a `Undefined index: message_id ` error. It occurred when trying to send a notification to an unregistered device token. As I stated in my issue before. Don't know if this (little) change should include any tests? This is my first PR, so any feedback is welcome! Commits ------- ac9c306 [Notifier] fix firebase error handling so the transports doesn't try setting the success message, that doesn't exists.
diff --git a/src/Symfony/Component/Notifier/Bridge/Firebase/FirebaseTransport.php b/src/Symfony/Component/Notifier/Bridge/Firebase/FirebaseTransport.php
@@ -89,8 +89,8 @@ protected function doSend(MessageInterface $message): SentMessage
 
             throw new TransportException('Unable to post the Firebase message: '.$errorMessage, $response);
         }
-        if ($jsonContents && isset($jsonContents['results']['error'])) {
-            throw new TransportException('Unable to post the Firebase message: '.$jsonContents['error'], $response);
+        if ($jsonContents && isset($jsonContents['results'][0]['error'])) {
+            throw new TransportException('Unable to post the Firebase message: '.$jsonContents['results'][0]['error'], $response);
         }
 
         $success = $response->toArray(false);

Original file line number	Diff line number	Diff line change
`@@ -89,8 +89,8 @@ protected function doSend(MessageInterface $message): SentMessage`
`89`	`89`
`90`	`90`	`throw new TransportException('Unable to post the Firebase message: '.$errorMessage, $response);`
`91`	`91`	`}`
`92`		`- if ($jsonContents && isset($jsonContents['results']['error'])) {`
`93`		`- throw new TransportException('Unable to post the Firebase message: '.$jsonContents['error'], $response);`
	`92`	`+ if ($jsonContents && isset($jsonContents['results'][0]['error'])) {`
	`93`	`+ throw new TransportException('Unable to post the Firebase message: '.$jsonContents['results'][0]['error'], $response);`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`$success = $response->toArray(false);`