8000 [SecurityBundle] Retrieve kernel.debug without checking its existence · symfony/symfony@8a28b3d · GitHub
[go: up one dir, main page]
Skip to content

Commit 8a28b3d

Browse files
l-vol-vo
committed
[SecurityBundle] Retrieve kernel.debug without checking its existence
1 parent e530caa commit 8a28b3d

File tree

5 files changed

+10
-2
lines changed

5 files changed

+10
-2
lines changed

‎src/Symfony/Bundle/SecurityBundle/DependencyInjection/Compiler/AddSecurityVotersPass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public function process(ContainerBuilder $container)
4343
throw new LogicException('No security voters found. You need to tag at least one with "security.voter".');
4444
}
4545

46-
$debug = $container->hasParameter('kernel.debug') && $container->getParameter('kernel.debug');
46+
$debug = $container->getParameter('kernel.debug');
4747

4848
foreach ($voters as $voter) {
4949
$voterServiceId = (string) $voter;

‎src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public function load(array $configs, ContainerBuilder $container)
102102
$loader->load('collectors.xml');
103103
$loader->load('guard.xml');
104104

105-
if ($container->hasParameter('kernel.debug') && $container->getParameter('kernel.debug')) {
105+
if ($container->getParameter('kernel.debug')) {
106106
$loader->load('security_debug.xml');
107107
}
108108

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Compiler/AddSecurityVotersPassTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ public function testNoVoters()
4040
public function testThatSecurityVotersAreProcessedInPriorityOrder()
4141
{
4242
$container = new ContainerBuilder();
43+
$container->setParameter('kernel.debug', false);
44+
4345
$container
4446
->register('security.access.decision_manager', AccessDecisionManager::class)
4547
->addArgument(array())
@@ -111,6 +113,7 @@ public function testThatVotersAreDecoratedInDebugMode(): void
111113
public function testThatVotersAreNotDecoratedWithoutDebugMode(): void
112114
{
113115
$container = new ContainerBuilder();
116+
$container->setParameter('kernel.debug', false);
114117

115118
$voterDef1 = new Definition(Voter::class);
116119
$voterDef1->addTag('security.voter');
@@ -138,6 +141,7 @@ public function testThatVotersAreNotDecoratedWithoutDebugMode(): void
138141
public function testVoterMissingInterface()
139142
{
140143
$container = new ContainerBuilder();
144+
$container->setParameter('kernel.debug', false);
141145
$container
142146
->register('security.access.decision_manager', AccessDecisionManager::class)
143147
->addArgument(array())

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/CompleteConfigurationTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -511,6 +511,8 @@ protected function getContainer($file)
511511
$file .= '.'.$this->getFileExtension();
512512

513513
$container = new ContainerBuilder();
514+
$container->setParameter('kernel.debug', false);
515+
514516
$security = new SecurityExtension();
515517
$container->registerExtension($security);
516518

‎src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/SecurityExtensionTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,8 @@ public function testDoNotRegisterTheUserProviderAliasWithMultipleProviders()
346346
protected function getRawContainer()
347347
{
348348
$container = new ContainerBuilder();
349+
$container->setParameter('kernel.debug', false);
350+
349351
$security = new SecurityExtension();
350352
$container->registerExtension($security);
351353

0 commit comments

Comments
 (0)
0