bug #44820 [Cache] Don't lock when doing nested computations (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 8a1c932321d7 · 2021-12-28T14:26:37.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Cache] Don't lock when doing nested computations | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41130 | License | MIT | Doc PR | - Commits ------- be8cbd2 [Cache] Don't lock when doing nested computations
diff --git a/src/Symfony/Component/Cache/LockRegistry.php b/src/Symfony/Component/Cache/LockRegistry.php
@@ -88,7 +88,7 @@ public static function compute(callable $callback, ItemInterface $item, bool &$s
 
         $key = self::$files ? abs(crc32($item->getKey())) % \count(self::$files) : -1;
 
-        if ($key < 0 || (self::$lockedFiles[$key] ?? false) || !$lock = self::open($key)) {
+        if ($key < 0 || self::$lockedFiles || !$lock = self::open($key)) {
             return $callback($item, $save);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ public static function compute(callable $callback, ItemInterface $item, bool &$s`
`88`	`88`
`89`	`89`	`$key = self::$files ? abs(crc32($item->getKey())) % \count(self::$files) : -1;`
`90`	`90`
`91`		`- if ($key < 0 \|\| (self::$lockedFiles[$key] ?? false) \|\| !$lock = self::open($key)) {`
	`91`	`+ if ($key < 0 \|\| self::$lockedFiles \|\| !$lock = self::open($key)) {`
`92`	`92`	`return $callback($item, $save);`
`93`	`93`	`}`
`94`	`94`