[Process] Fix write access check for pipes on Windows

nicolas-grekas · nicolas-grekas · commit 8a1ac8d51d73 · 2016-07-25T22:38:31.000+02:00
diff --git a/src/Symfony/Component/Process/Pipes/WindowsPipes.php b/src/Symfony/Component/Process/Pipes/WindowsPipes.php
@@ -52,17 +52,20 @@ public function __construct($input, $haveReadSupport)
                 Process::STDERR => Process::ERR,
             );
             $tmpDir = sys_get_temp_dir();
-            if (!@fopen($file = $tmpDir.'\\sf_proc_00.check', 'wb')) {
-                throw new RuntimeException('A temporary file could not be opened to write the process output to, verify that your TEMP environment variable is writable');
-            }
-            @unlink($file);
+            set_error_handler(function () { return false; });
             for ($i = 0;; ++$i) {
                 foreach ($pipes as $pipe => $name) {
                     $file = sprintf('%s\\sf_proc_%02X.%s', $tmpDir, $i, $name);
                     if (file_exists($file) && !@unlink($file)) {
                         continue 2;
                     }
-                    $h = @fopen($file, 'xb');
+                    if (!$h = @fopen($file, 'xb')) {
+                        $e = error_get_last();
+                        if (!$e || false === strpos($e['message'], 'File exists')) {
+                            restore_error_handler();
+                            throw new RuntimeException('A temporary file could not be opened to write the process output to, verify that your TEMP environment variable is writable');
+                        }
+                    }
                     if (!$h || !$this->fileHandles[$pipe] = fopen($file, 'rb')) {
                         continue 2;
                     }
@@ -73,6 +76,7 @@ public function __construct($input, $haveReadSupport)
                 }
                 break;
             }
+            restore_error_handler();
         }
 
         parent::__construct($input);
