bug #24575 Ensure that PHPUnit's error handler is still working in isolated tests (alexpott)

nicolas-grekas · nicolas-grekas · commit 8984260f3888 · 2017-10-24T19:15:55.000+02:00
This PR was squashed before being merged into the 3.3 branch (closes #24575). Discussion ---------- Ensure that PHPUnit's error handler is still working in isolated tests | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no  | BC breaks? | no | Deprecations? | no  | Tests pass? | yes | Fixed tickets | #...  | License | MIT | Doc PR | symfony/symfony-docs#...   This PR fixes the \Symfony\Bridge\PhpUnit\Tests\ProcessIsolationTest and adds new coverage to ensure PHPUnit error handling works as expected. Tested with both PHPUnit 4.8.35 and 6.2.4 Commits ------- dc7e5a3 Ensure that PHPUnit's error handler is still working in isolated tests
diff --git a/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php b/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php
@@ -255,6 +255,12 @@ public static function collectDeprecations($outputFile)
             }
             $deprecations[] = array(error_reporting(), $msg);
         });
+        // This can be registered before the PHPUnit error handler.
+        if (!$previousErrorHandler) {
+            $UtilPrefix = class_exists('PHPUnit_Util_ErrorHandler') ? 'PHPUnit_Util_' : 'PHPUnit\Util\\';
+            $previousErrorHandler = $UtilPrefix.'ErrorHandler::handleError';
+        }
+
         register_shutdown_function(function () use ($outputFile, &$deprecations) {
             file_put_contents($outputFile, serialize($deprecations));
         });
diff --git a/src/Symfony/Bridge/PhpUnit/Tests/ProcessIsolationTest.php b/src/Symfony/Bridge/PhpUnit/Tests/ProcessIsolationTest.php
@@ -21,4 +21,17 @@ public function testIsolation()
         @trigger_error('Test abc', E_USER_DEPRECATED);
         $this->addToAssertionCount(1);
     }
+
+    public function testCallingOtherErrorHandler()
+    {
+        $class = class_exists('PHPUnit\Framework\Exception') ? 'PHPUnit\Framework\Exception' : 'PHPUnit_Framework_Exception';
+        if (method_exists($this, 'expectException')) {
+            $this->expectException($class);
+            $this->expectExceptionMessage('Test that PHPUnit\'s error handler fires.');
+        } else {
+            $this->setExpectedException($class, 'Test that PHPUnit\'s error handler fires.');
+        }
+
+        trigger_error('Test that PHPUnit\'s error handler fires.', E_USER_WARNING);
+    }
 }
