minor #51337 [AssetMapper] Improve the error message when a downloaded file is missing (jmsche)

nicolas-grekas · nicolas-grekas · commit 897a05491194 · 2023-08-23T22:11:00.000+02:00
This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [AssetMapper] Improve the error message when a downloaded file is missing | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A When a file downloaded using the `importmap:require [packageName] --download` command is missing, the error message is this one: > The asset "vendor/`@hotwired`/stimulus.js" mentioned in "importmap.php" cannot be found in any asset map paths. This PR slightly improves the error message to explain how it can be fixed: > The "vendor/`@hotwired`/stimulus.js" downloaded asset is missing. Run "php bin/console importmap:require `@hotwired`/stimulus --download". Commits ------- 06fb6fe [AssetMapper] Improve the error message when a downloaded file is missing
diff --git a/src/Symfony/Component/AssetMapper/ImportMap/ImportMapManager.php b/src/Symfony/Component/AssetMapper/ImportMap/ImportMapManager.php
@@ -382,6 +382,10 @@ private function convertEntriesToImports(array $entries): array
 
             if (null !== $entryOptions->path) {
                 if (!$asset = $this->assetMapper->getAsset($entryOptions->path)) {
+                    if ($entryOptions->isDownloaded) {
+                        throw new \InvalidArgumentException(sprintf('The "%s" downloaded asset is missing. Run "php bin/console importmap:require "%s" --download".', $entryOptions->path, $entryOptions->importName));
+                    }
+
                     throw new \InvalidArgumentException(sprintf('The asset "%s" mentioned in "%s" cannot be found in any asset map paths.', $entryOptions->path, basename($this->importMapConfigPath)));
                 }
                 $path = $asset->publicPath;
